stream-chat-swift
stream-chat-swift copied to clipboard
Allow to pin any message
๐ Issue Links
Resolve https://github.com/GetStream/ios-issues-tracking/issues/782
๐ฏ Goal
Allow to pin any message
๐ Summary
- Replace
update
withpartial update
on pinning the message - Update DemoApp pinning logic
๐จ Showcase
๐งช Manual Testing Notes
-
Pin the current user's message
-
Pin the participant's message
-
Login as a participant => Verify that messages are pinned with correct labels
-
Unpin the current user's message
-
Unpin the participant's message
-
Login as a participant => Verify that messages are unpinned
โ๏ธ Contributor Checklist
- [x] I have signed the Stream CLA (required)
- [x] This change follows zero โ ๏ธ policy (required)
- [x] This change should be manually QAed
- [ ] Changelog is updated with client-facing changes
- [ ] New code is covered by unit tests
- [ ] Comparison screenshots added for visual changes
- [ ] Affected documentation updated (docusaurus, tutorial, CMS)
๐ Meme
StreamChat XCMetrics
target |
metric |
benchmark |
branch |
performance |
status |
---|---|---|---|---|---|
MessageList | Hitches total duration | 10 ms | 8.34 ms | 16.6% ๐ผ | ๐ข |
Duration | 2.6 s | 2.55 s | 1.92% ๐ผ | ๐ข | |
Hitch time ratio | 4 ms per s | 3.28 ms per s | 18.0% ๐ผ | ๐ข | |
Frame rate | 79 fps | 78.21 fps | 1.0% ๐ผ | ๐ข | |
Number of hitches | 1 | 0.6 | 40.0% ๐ผ | ๐ข | |
ChannelList | Hitches total duration | 12.5 ms | 2.5 ms | 80.0% ๐ผ | ๐ข |
Duration | 2.6 s | 0.82 s | 68.46% ๐ผ | ๐ข | |
Hitch time ratio | 5 ms per s | 3.03 ms per s | 39.4% ๐ผ | ๐ข | |
Frame rate | 76 fps | 63.75 fps | 16.12% ๐ผ | ๐ข | |
Number of hitches | 1.2 | 0.2 | 83.33% ๐ผ | ๐ข |
Quality Gate passed
Issues
66 New issues
0 Accepted issues
Measures
0 Security Hotspots
83.8% Coverage on New Code
0.0% Duplication on New Code