stream-chat-swift icon indicating copy to clipboard operation
stream-chat-swift copied to clipboard

Allow to pin any message

Open testableapple opened this issue 2 months ago โ€ข 3 comments

๐Ÿ”— Issue Links

Resolve https://github.com/GetStream/ios-issues-tracking/issues/782

๐ŸŽฏ Goal

Allow to pin any message

๐Ÿ“ Summary

  • Replace update with partial update on pinning the message
  • Update DemoApp pinning logic

๐ŸŽจ Showcase

๐Ÿงช Manual Testing Notes

  1. Pin the current user's message

  2. Pin the participant's message

  3. Login as a participant => Verify that messages are pinned with correct labels

  4. Unpin the current user's message

  5. Unpin the participant's message

  6. Login as a participant => Verify that messages are unpinned

โ˜‘๏ธ Contributor Checklist

  • [x] I have signed the Stream CLA (required)
  • [x] This change follows zero โš ๏ธ policy (required)
  • [x] This change should be manually QAed
  • [ ] Changelog is updated with client-facing changes
  • [ ] New code is covered by unit tests
  • [ ] Comparison screenshots added for visual changes
  • [ ] Affected documentation updated (docusaurus, tutorial, CMS)

๐ŸŽ Meme

gif

testableapple avatar Apr 24 '24 16:04 testableapple

StreamChat XCMetrics

target metric benchmark branch performance status
MessageList Hitches total duration 10 ms 8.34 ms 16.6% ๐Ÿ”ผ ๐ŸŸข
Duration 2.6 s 2.55 s 1.92% ๐Ÿ”ผ ๐ŸŸข
Hitch time ratio 4 ms per s 3.28 ms per s 18.0% ๐Ÿ”ผ ๐ŸŸข
Frame rate 79 fps 78.21 fps 1.0% ๐Ÿ”ผ ๐ŸŸข
Number of hitches 1 0.6 40.0% ๐Ÿ”ผ ๐ŸŸข
ChannelList Hitches total duration 12.5 ms 2.5 ms 80.0% ๐Ÿ”ผ ๐ŸŸข
Duration 2.6 s 0.82 s 68.46% ๐Ÿ”ผ ๐ŸŸข
Hitch time ratio 5 ms per s 3.03 ms per s 39.4% ๐Ÿ”ผ ๐ŸŸข
Frame rate 76 fps 63.75 fps 16.12% ๐Ÿ”ผ ๐ŸŸข
Number of hitches 1.2 0.2 83.33% ๐Ÿ”ผ ๐ŸŸข

Stream-iOS-Bot avatar Apr 24 '24 16:04 Stream-iOS-Bot