stream-chat-swift
stream-chat-swift copied to clipboard
Ext video apis
2 Warnings | |
---|---|
:warning: | Big PR |
:warning: | Please provide a summary in the Pull Request description |
1 Message | |
---|---|
:book: | There seems to be app changes but CHANGELOG wasn't modified. Please include an entry if the PR includes user-facing changes. You can find it at CHANGELOG.md. |
Generated by :no_entry_sign: Danger
📏 Size Analysis
Total install size 9.7 MB | This change: ⬆️ +78.8 kB (+0.815%)
🗂 See size breakdown
Item | Install size |
---|---|
StreamChat.framework/StreamChat.DefaultRequestDecoder.decodeRequestResponse(data,response,error) | ⬆️ 7.2 kB |
StreamChat.framework/StreamChat.APIClient.executeRequest(endpoint,completion) | ⬆️ 3.7 kB |
➕ StreamChat.framework/StreamChat.ChatChannelController.createCall(id,type,completion) | ⬆️ 2.6 kB |
StreamChat.framework/StreamChat.APIClient.operation(endpoint,isRecoveryOperation,completion) | ⬆️ 2.6 kB |
StreamChat.framework/Code Signature | ⬆️ 2.2 kB |
StreamChat.framework/StreamChat.DefaultRequestEncoder.encodeRequest(for,completion) | ⬆️ 2.1 kB |
StreamChat.framework/DYLD.Exports | ⬆️ 1.9 kB |
StreamChat.framework/StreamChat.Optional | ⬆️ 1.6 kB |
➕ StreamChat.framework/StreamChat.CallWithToken.value witness | ⬆️ 1.3 kB |
➕ StreamChat.framework/StreamChat.CallRepository.createCall(in,callId,type,completion) | ⬆️ 1.3 kB |
➕ StreamChat.framework/StreamChat.Call.value witness | ⬆️ 1.2 kB |
➕ StreamChat.framework/StreamChat.CreateCallPayload.value witness | ⬆️ 1.1 kB |
➕ StreamChat.framework/StreamChat.CreateCallPayload.init(from) | 924 B |
➕ StreamChat.framework/StreamChat.CallPayload.value witness | 876 B |
➕ StreamChat.framework/StreamChat.CallPayload.init(from) | 856 B |
StreamChat.framework/StreamChat.APIClient.refreshToken(completion) | 740 B |
StreamChat.framework/StreamChat.framework/StreamChat | 640 B |
➕ StreamChat.framework/StreamChat.CreateCallPayload.__derived_struct_equals | 600 B |
➕ StreamChat.framework/StreamChat.CreateCallPayload.CreateCallPayload | 568 B |
➕ StreamChat.framework/StreamChat.CallWithToken.__derived_struct_equals | 556 B |
🔎 See the full size analysis (fe7b905) merging into develop (64e9493)
Provide a baseSha and pullRequestNumber with your upload to ensure diffs are correct. Read more in the docs
@martinmitrevski I cherry picked and squashed the work by @tbarbugli.
What needs to happen to get this in a mergable state?
@martinmitrevski I cherry picked and squashed the work by @tbarbugli.
What needs to happen to get this in a mergable state?
@jeroenleenarts, I would say first the checks need to pass (tests, etc), also more coverage is needed. Also, a look by @polqf would be more than welcome :)
I created a few tests. Not sure if those are sufficient since SonarCloud is still complaining. If there's more to test, I'm happy to do so! What do you think @nuno-vieira and @martinmitrevski ?