stream-chat-react icon indicating copy to clipboard operation
stream-chat-react copied to clipboard

bug: the separateGiphyPreview flag among VirtualizedMessageList props has no effect

Open MartinCupela opened this issue 3 years ago • 1 comments

Describe the bug

The giphy preview is always rendered outside the message list even though the value of separateGiphyPreview prop is set to false. The preview is always rendered inside the <div> element with class giphy-preview-message below the message notifications elements.

This is caused by the use of processMessages function inside the VirtualizedMessageList. This function always sets the giphy preview:

https://github.com/GetStream/stream-chat-react/blob/f23a3766e9b750f9c11e8bbd8bbfb5b9b8112a4a/src/components/MessageList/utils.ts#L76

To Reproduce

Toggle the value of separateGiphyPreview on VirtualizedMessageList.

Expected behavior

Probably render the preview inside the message list. Can this prop be deprecated as there are no complaints about the current behavior?

Package version

  • stream-chat-react: 9.5.0

MartinCupela avatar Aug 30 '22 09:08 MartinCupela

Hello, is there any update on this? Could you add a line in the doc too I spent some time wondering why it was not working? Also it would be actually good to render the component where we want (just link it to a context so we could render it where we want).

Also I have an other bug, the GiphyPreview component does not show up directly (I need to send a second message to have it, it seems the event listening is not working properly I think it's related?)

Thank you!

lr-mjaouen avatar Feb 23 '23 17:02 lr-mjaouen

:tada: This issue has been resolved in version 11.20.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

stream-ci-bot avatar Jun 07 '24 18:06 stream-ci-bot