stream-chat-react-native
stream-chat-react-native copied to clipboard
fix: overwriting of the translation files when running test or build script
๐ฏ Goal
This PR fixes the issue of overwriting the translation files every time we run the build/test script.
๐ Implementation details
The plugin is removed from the babel.config.js
and .babelrc
. This is still used under the build-translations
script so it doesn't need to be present in the config files. The overwriting was probably because of its usage at two places, but the clean-up was done only once.
๐จ UI Changes
iOS
Before | After |
Android
Before | After |
๐งช Testing
โ๏ธ Checklist
- [x] I have signed the Stream CLA (required)
- [x] PR targets the
develop
branch - [ ] Documentation is updated
- [x] New code is tested in main example apps, including all possible scenarios
- [x] SampleApp iOS and Android
- [x] Expo iOS and Android
Kudos, SonarCloud Quality Gate passed!ย ย
Lets keep this on hold for a bit!! I will need some time to test it out
@khushal87 can you add steps under testing to let us know how to validate this behaviour?
@khushal87 seems like our translation system is broken somehow on develop. We used to be able to generate translation files using build-translation command. In this PR you are removing all the config which we use to generate those translations. I don't think thats the right way, we should first investigate why is it broken, and then fix it ... and then handle this linting issue.
Closing this if this doesn't make sense. @vishalnarkhede
Probably this isn't the right way of going with it.