stream-chat-react-native icon indicating copy to clipboard operation
stream-chat-react-native copied to clipboard

fix: overwriting of the translation files when running test or build script

Open khushal87 opened this issue 2 years ago โ€ข 2 comments

๐ŸŽฏ Goal

This PR fixes the issue of overwriting the translation files every time we run the build/test script.

๐Ÿ›  Implementation details

The plugin is removed from the babel.config.js and .babelrc. This is still used under the build-translations script so it doesn't need to be present in the config files. The overwriting was probably because of its usage at two places, but the clean-up was done only once.

๐ŸŽจ UI Changes

iOS
Before After
Android
Before After

๐Ÿงช Testing

โ˜‘๏ธ Checklist

  • [x] I have signed the Stream CLA (required)
  • [x] PR targets the develop branch
  • [ ] Documentation is updated
  • [x] New code is tested in main example apps, including all possible scenarios
    • [x] SampleApp iOS and Android
    • [x] Expo iOS and Android

khushal87 avatar Jul 19 '22 07:07 khushal87

Kudos, SonarCloud Quality Gate passed!ย  ย  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Jul 19 '22 07:07 sonarqubecloud[bot]

Lets keep this on hold for a bit!! I will need some time to test it out

vishalnarkhede avatar Jul 25 '22 11:07 vishalnarkhede

@khushal87 can you add steps under testing to let us know how to validate this behaviour?

vanGalilea avatar Sep 06 '22 08:09 vanGalilea

@khushal87 seems like our translation system is broken somehow on develop. We used to be able to generate translation files using build-translation command. In this PR you are removing all the config which we use to generate those translations. I don't think thats the right way, we should first investigate why is it broken, and then fix it ... and then handle this linting issue.

vishalnarkhede avatar Sep 06 '22 15:09 vishalnarkhede

Closing this if this doesn't make sense. @vishalnarkhede

Probably this isn't the right way of going with it.

khushal87 avatar Sep 14 '22 12:09 khushal87