stream-chat-react-native icon indicating copy to clipboard operation
stream-chat-react-native copied to clipboard

Published 20 hours ago • verified publisher icon GetStream

Use PNPM throughout project

Open vanGalilea opened this issue 2 years ago • 4 comments

Motivation @madsroskar is constantly frustrated with yarn, and node modules are being managed.

Proposed solution Use ppnpm by following where @madsroskar left in this PR

Acceptance Criteria pnpm is easy to use and configured correctly through our project. Migration from yarn to pnpm is well documented in readme/contribution MD and communicated to all collaborators.

vanGalilea avatar May 05 '22 09:05 vanGalilea

Tricky parts to deal with:

  • [ ] release scripts will have to be refactored
  • [ ] Example apps using metro, will need custom metro config

madsroskar avatar May 24 '22 08:05 madsroskar

Hey team! Please add your planning poker estimate with ZenHub @Enigma-I-am @khushal87 @madsroskar @santhoshvai @vishalnarkhede

vanGalilea avatar May 24 '22 08:05 vanGalilea

@madsroskar https://microsoft.github.io/rnx-kit/docs/tools/metro-resolver-symlinks this could help with pnpm symlink easiness

santhoshvai avatar May 25 '22 08:05 santhoshvai

Another note for this project: Test thoroughly with EAS, and ensure version dependencies are up to date, as flexible as they can be, and well documented against expo and other libraries.

Currently stream-chat-expo has a lot of outdated dependencies. IE - @react-native-community/netinfo@^6, but latest is 7. I use 7 and other dependencies I have need 7.

My builds on EAS fail unless I set strict-peer-dependencies=false in my .npmrc. Which removes some of the benefit of pnpm.

jrobber avatar Jun 10 '22 17:06 jrobber

This issue was moved to an internal backlog list of less urgent feature/docs requests.

vanGalilea avatar Oct 13 '22 08:10 vanGalilea