stream-chat-android icon indicating copy to clipboard operation
stream-chat-android copied to clipboard

Fix display of message background when selecting a message and showing a menu

Open filbabic opened this issue 2 years ago • 1 comments

Context & proposal

As per the discussion when applying a custom message style through transformations and a custom message item type.

Acceptance criteria

To accept this task we need to complete the following items:

  • [ ] Make sure custom message styling and types are shown when selecting the messages.

filbabic avatar Jun 07 '22 09:06 filbabic

Update: This is caused by having custom items that don't have a background by default (e.g. transparent, slack-style messages) and then selecting them. In this scenario, we would need to do one of the following:

  • Enable a customization option/attribute that adds a bubble and/or a background to the message text, in case of custom plain text messages.
  • Enable a way for users to saturate and change the message state/data before we display the dialog, to trigger their own custom logic.
  • Enable users to show the message options dialog themselves (expose a public builder or sth) and then have them react to the handler, update the state and show the dialog.
  • Have a way to provide a single factory for message items, but allow for a slightly customized behavior when showing them in the selected menu (e.g. a SelectedMessageTransformer that applies some changes to the given message ViewHolder)

filbabic avatar Jun 07 '22 10:06 filbabic

Closing as it's not been required for a while - also was a custom design issue.

filbabic avatar Oct 10 '22 11:10 filbabic