Publii icon indicating copy to clipboard operation
Publii copied to clipboard

[Bug]: Theme/Website primary logos should not be lazily loaded.

Open m00tiny opened this issue 2 years ago • 2 comments

Operating system

Manjaro Linux

Publii version

Latest Stable

Post editor

No response

Bug description

When enabling lazy loading of images, the main or primary logo should not be lazily loaded. It is always rendered above the fold.

Steps to reproduce

Enable lazy loading, sync website.

Relevant log output

No response

m00tiny avatar Apr 10 '22 12:04 m00tiny

What theme do you use?

bobmitro avatar Apr 11 '22 13:04 bobmitro

Technews 2.4.0.0

I apologize if it is not maintained by the Publii team. I assumed all of the open themes were, and now realize that could've been an error or that this may not be the right place to submit the issue.

m00tiny avatar Apr 14 '22 22:04 m00tiny

I am closing this issue as it is not strictly related to the Publii core but to the themes.

dziudek avatar Sep 02 '22 16:09 dziudek

I am closing this issue as it is not strictly related to the Publii core but to the themes.

I'm not objecting to closing it. But, to be clear, I simply didn't myself test with any other themes. But, I would assume it has more to do with the Lazy Loading code than any particular theme.

To be clear, I no longer use Publii, I can't imagine this having much of an effect on time to load or first paint or whatever and the only thing I can picture flagging this kind of thing is some cranky SEO tool.. it might be a Google cranky SEO tool, but a cranky SEO tool none-the-less.. I doubt it shaves more than the smallest of an unnoticeable amount off of any kind of ranking.. so unless you're selling clothing online (so competitive!), it's not going to matter.. probably.

On the other hand, if the browser has to process a gigantic JS file, simply because images "above the fold" are flagged with Lazy Load on every single page, maybe it is defeating the a large portion of the purpose for having lazy loading on any website outside of an image gallery.

m00tiny avatar Sep 10 '22 15:09 m00tiny