atlantis icon indicating copy to clipboard operation
atlantis copied to clipboard

New pattern & components - Header -> Sidebar -> Page -> Footer

Open si4star opened this issue 2 years ago • 2 comments

I'm surprised to see the Page component. The semantic approach to producing a page would be Header -> Content -> Footer - so the concept of a Page element doesn't really fit my understanding of good semantics.

It would be bad practice to break the page over two components

Header Component = <Page> <Content /> Footer Component = </Page>

Header Component where the Title, subtitles and intro all modified based on route but the general header structure remains the same

<Content /> where the page or views content sites

Footer Component = The end of the page - be it a footer or whatever closes your correctly

Header and Footer components could be extended - or app headers could include Atlantis headers.

I'm also surprised to see there are no navigation or sidebar elements despite that structure being used on getjobber.com (sidebar/header/navigation) and the report scheduler (header/navigation).

I think this is a really important area to address if you want developers to use Atlantis - as at the moment it just gets messy if I try to use the Page pattern you're suggesting.

si4star avatar May 26 '22 19:05 si4star