atlantis icon indicating copy to clipboard operation
atlantis copied to clipboard

fix(components-native): Fix Form's bottom inset SafeArea for inline type FormActionBar

Open krakitine opened this issue 4 months ago • 2 comments

Motivations

Form's FormActionBar (save button) on Android devices with edge-to-edge enabled was showing Form content over the navigation. This PR adds a fix to add proper insets for "inline" style FormActionBar

Before

borked

After

fixed

Changes

Fixed

  • Fix Form's bottom inset SafeArea for inline type FormActionBar

Testing

I tested using three Android emulators. One with Android 14, two with Android 16 (one using gesture navigation, the other button navigation) Use an android build with edge-to-edge enabled. Load up a form long enough that it has a scroll. Notice that on the Android that supports edge-to-edge (15+), the form content is not visible over the bottom system navigation bar

Changes can be tested via Pre-release

krakitine avatar Nov 12 '25 21:11 krakitine

Published Pre-release for 547612b28b6ea97cd710210ecbbe6917da0c9734 with versions:

  - @jobber/[email protected]+547612b28

To install the new version(s) for Mobile run:

npm install @jobber/[email protected]+547612b28

github-actions[bot] avatar Nov 13 '25 14:11 github-actions[bot]

Blocking this guy for when we resume this a little later. Keeping PR around as we might still use this

krakitine avatar Nov 14 '25 20:11 krakitine