atlantis icon indicating copy to clipboard operation
atlantis copied to clipboard

feat(components): Decouple shadow from clickability [JOB-105101]

Open Aiden-Brine opened this issue 4 months ago • 2 comments

Motivations

It was requested that the presence of a drop shadow on a card not depend on if the card is clickable and instead is controllable via an elevation prop. Note that this PR should be reviewed at the same time since it adds breaking changes.

Changes

Removed the drop shadow CSS from clickable cards

Added

An elevation prop to the Card component which controls if the card has a drop shadow

Changed

Cards will no longer automatically have a drop shadow if they are clickable. Instead, the presence of drop-shadow depends on the new elevation prop

Deprecated

N/A

Removed

N/A

Fixed

N/A

Security

N/A

Testing

I added a new elevation story and this should be testable via Storybook. You can also test it with the pre-release included here

Changes can be tested via Pre-release


In Atlantis we use Github's built in pull request reviews.

Random photo of Atlantis

Aiden-Brine avatar Oct 02 '24 17:10 Aiden-Brine