atlantis
atlantis copied to clipboard
feat(components): Add action menu to FormatFile
Motivations
This is a POC to see what an actions menu would involve on FormatFile
.
There may be more actions than just delete
moving forward on the FormatFile
component (ex. download
).
Instead of adding an onDownload
prop which is just another callback, we can open up a menu to allow for endless customizable options in the future.
Added
- added a
FormatFileMenu
component withinFormatFile
Not done yet/future considerations
- focus state/accessibility/keyboard events
- deprecating
onDelete
- should there be a menu even if there's only one action? Right now the logic is if
actions?.length > 0
- further styling (colour of text on destructive, etc)
- size of the menu button while
compact
&base
props are in effect
Changes can be tested via Pre-release
In Atlantis we use Github's built in pull request reviews.