atlantis icon indicating copy to clipboard operation
atlantis copied to clipboard

Published 20 hours ago • verified publisher icon GetJobber

fix(components): Allow Button variation prop combined with submit prop

Open jdeichert opened this issue 9 months ago • 1 comments

Motivations

When a Button had submit, TS disallowed variation because we were extending ButtonFoundationProps instead of BaseActionProps. Confirmed with Chris, allowing variation combined with submit makes sense.

Changes

Changed

  • Updated Button prop types to allow variation + submit

In Atlantis we use Github's built in pull request reviews.

jdeichert avatar May 15 '24 22:05 jdeichert