refactor(components): Adjust Combobox onSearch Prop Logic

[ZakaryH]

Motivations

I wasn't the biggest fan of passing around a noop and eventually calling it with some arguments

tried to think of a way to do it that I liked more. this is hopefully that.

Changes

really just swapped from it being a noop in the case where we don't need an extra on search callback to being undefined and now we won't attempt to call this method if it was undefined

then some minor name and internal prop doc updates

oh and changed the debounced function from being a useCallback that gets invoked on each re-render to a useMemo that won't as per a suggestion from Jacob!

Added

Changed

Deprecated

Removed

Fixed

Security

Testing

---

In Atlantis we use Github's built in pull request reviews.