atlantis icon indicating copy to clipboard operation
atlantis copied to clipboard

refactor(components): Separating Chip and Chips (for real this time)

Open scotttjob opened this issue 1 year ago • 1 comments

Motivations

We needed a standalone Chip for DataList/ClientList/Combobox. Since our existing implementation required a group of chips, an effort began to redesign Chip, implement that new Chip, and then decouple Chip from Chips. We've already redesigned and implemented the new Chip, this is the final step, decoupling Chip from Chips.

The original version of this PR made a critical mistake early on, deleting the InternalChip file instead of using it to properly integrate the new Chip component. This version of the PR corrects that mistake, and as a result this is a drastically simpler PR, with less breaking changes.

Changes

Chips no longer has its own internal implementation of a Chip, instead using the decoupled/unopinionated <Chip> that is also available to all consumers of Atlantis.

Previous Chips Single Select

image

New Chips Single Select

image

Previous Chips Multi Select

image

New Chips Multi Select

image

Previous Chips Selection

image

New Chips Selection

image

Added

  • No net new development

Changed

  • There should be no noticeable changes by consumers of Atlantis other than the design of Chips is now in line with Chip.

Deprecated

  • N/A

Removed

  • N/A

Fixed

  • N/A

Security

  • N/A

Testing

  1. Ensured all existing functionality in storybook is preserved.
  2. Ensured all existing unit tests pass with the changes.

In Atlantis we use Github's built in pull request reviews.

Random photo of Atlantis

scotttjob avatar Dec 18 '23 17:12 scotttjob