atlantis icon indicating copy to clipboard operation
atlantis copied to clipboard

Remove 'to' prop from button component

Open dlrussel opened this issue 1 year ago • 0 comments

https://github.com/GetJobber/atlantis/blob/616c498cc1bfeedcc752700c6bcbc64f4f914350/packages/components/src/Button/Button.tsx#L146

We should remove the to prop from the button component that is used to create a button that returns a Link. This creates a confusing implementation because we shouldn't be building link functionality into our button component. Links should be used to move to another page or move to another place within the same page while Buttons are for triggering actions.

dlrussel avatar Sep 14 '23 19:09 dlrussel