dkan2 icon indicating copy to clipboard operation
dkan2 copied to clipboard

Fix code climate complexity issues

Open janette opened this issue 4 years ago • 0 comments

  • [ ] Method formElement has 5 arguments (exceeds 4 allowed).
public function formElement(FieldItemListInterface $items, $delta, array $element, array &$f

Found in modules/custom/json_schema_field/src/Plugin/Field/FieldWidget/JsonSchemaFormWidget.php


  • [ ] Method __construct has 5 arguments (exceeds 4 allowed).
public function __construct(array $configuration, $plugin_id, $plugin_definition, Connection

Found in modules/dkan_non_public/src/Plugin/DataModifier/NonPublicResourceProtector.php


  • [ ] ComplexDataFacade has 24 functions (exceeds 20 allowed).
class ComplexDataFacade implements \Iterator, ComplexDataInterface {

Found in modules/dkan_search/src/Facade/ComplexDataFacade.php


  • [ ] Method __construct has 6 arguments (exceeds 4 allowed).
Service $service,
    Connection $database,
    Resource $resourceServiceFactory,
    RequestStack $requestStack,
    DatabaseTableFactory $databaseTableFactory,

Found in modules/dkan_sql_endpoint/src/Controller/Api.php


  • [ ] Function expandDirectories has a Cognitive Complexity of 8 (exceeds 5 allowed).
private function expandDirectories($base_dir) {
    $directories = [];
 
    if (!file_exists($base_dir)) {
      return $directories;

Found in modules/dkan_frontend/src/Routing/RouteProvider.php

janette avatar Apr 07 '20 21:04 janette