Show 100% when import done in info/dashboard.
In the output from dataset-info, and by extension in the datastore import dashboard, we have a longstanding issue where when using the mysql import module, the percent done stays at zero (0) even though the import process has finished. This is because the mysql importer performs the entire import at once and provides no feedback on amount complete. It was, in hindsight, not such a good idea to assume any job like this would provide "bites processed" information and build the whole dataset info gathering workflow around that assumption.
While the dataset info and datastore dashboard are probably both due for an overhaul, for now we just want coherent information provided to the user. We had two options:
- Remove the percent done measure completely for import, as we did for filefetcher, or
- Force the value to be 100 if the status is "done".
Since the percent done is still useful for people using the CSV parser, and the status value seems to be more reliable than the bytes processed value, I went with #2. This is definitely to be considered a stopgap.
QA Steps
- Install new vanilla site, enable datastore_mysql_import
- Import sample content
- Visit datastore import dashboard. Confirm that one any imports that are "done," it reads "100%" not "0%".