dkan icon indicating copy to clipboard operation
dkan copied to clipboard

#4068: Provide number widget

Open stefan-korn opened this issue 1 year ago • 3 comments

fixes #4068

  • [ ] Test coverage exists
  • [ ] Documentation exists

QA Steps

  • [ ] Add manual QA steps in checklist format for a reviewer to perform to confirm that the feature or fix is working. Include as much details as possible so that the reviewer doesn't lose time figuring out how to perform steps.

stefan-korn avatar Nov 27 '23 16:11 stefan-korn

@stefan-korn this would need test coverage before it can be merged.

janette avatar Dec 04 '23 23:12 janette

@stefan-korn are you able to add some coverage? The easiest thing would probably be to add a number field to Drupal\Tests\json_form_widget\Unit\JsonFormBuilderTest

dafeder avatar Dec 11 '23 17:12 dafeder

@dafeder : I addressed your comments.

Regarding "number" in the schema. I wasn't aware that there is the integer field. It is only used once in the data-dictionary.json I suppose and we do not need data dictionary right now, so I missed that.

Should the schema be configurable about step, min and max? That way no widget "number" would be needed at all?

stefan-korn avatar Apr 24 '24 05:04 stefan-korn

@stefan-korn re-thinking this I think the "number" field in the schema itself can be dealt with separately, should not be a blocker for this. I did a new PR from this that hits the test coverage, closing this in favor of #4215. Thanks!

dafeder avatar Jul 03 '24 13:07 dafeder