dkan icon indicating copy to clipboard operation
dkan copied to clipboard

Use drupal's httpclient

Open sandeepguntaka opened this issue 2 years ago • 2 comments

Using drupal's default http client helps in building client object with global http client config.

fixes [org/repo/issue#]

  • [ ] Test coverage exists
  • [ ] Documentation exists

QA Steps

  • [ ] Add manual QA steps in checklist format for a reviewer to perform to confirm that the feature or fix is working. Include as much details as possible so that the reviewer doesn't lose time figuring out how to perform steps.

sandeepguntaka avatar May 03 '22 17:05 sandeepguntaka

Hi - @sandeepguntaka open to this but as you can see it needs more work to get the tests to work. Hopefully you're able to run the tests locally and debug them? If you get the tests passing again we can probably merge this.

dafeder avatar May 25 '22 13:05 dafeder

Hi - @sandeepguntaka open to this but as you can see it needs more work to get the tests to work. Hopefully you're able to run the tests locally and debug them? If you get the tests passing again we can probably merge this.

I still see an issue with mocking guzzle's client, will fix that too and push the changes soon.

sandeepguntaka avatar May 25 '22 15:05 sandeepguntaka

It looks like this was added as part of #4084

Thanks!

paul-m avatar Feb 01 '24 22:02 paul-m