Germán Jabloñski

Results 133 comments of Germán Jabloñski

- I'm ok with a solution like canMergeWhenEmpty. My only observation is that isLi is still used in one more place. If it is replaced by canMergeWhenEmpty, does any test...

1. It seems fine to me. 2. My intuition tells me that both should be included in the quote, although I don't have strong opinions on the matter. Maybe someone...

Thanks for your response! @nickmccurdy totally agree! I also reasoned that if the `cypress` folder was being ignored, then `playwright` should be ignored as well. @sheremet-va The discussion with the...

Yes, I think the dilemma is between excluding `playwgright` and `e2e-tests` or excluding `playwright` only. If it's for me, my vote is in favor of excluding both ✋

@silverwind Do they have Vitest tests inside `tests/e2e`? If so, could I know why?

Oh, gitea is cool! 👌 Well, what you mention confirms the point of this issue, which is make _`Vitest`_ ignore the e2e folder ___________ By the way, I would like...

Well @sheremet-va, I already got the point about e2e in Vitest, thanks for clearing it up. Regarding Playwright and Cypress, since I see that some of you do not have...

Thanks to @yaojiu19 for offering to contribute to this issue, although that PR doesn't solve the problem in "the lexical way" as the maintainers mentioned there. I'm willing to solve...

I don’t see why I would be responsible for PR 5930 being stalled. If that's the case for some reason, I encourage anyone who wants to continue it :) As...