bmi-calculator icon indicating copy to clipboard operation
bmi-calculator copied to clipboard

Removing the MaterializeCSS dependency

Open GermaVinsmoke opened this issue 4 years ago • 15 comments

There isn't much use of MaterializeCSS, so it's better to remove it.

GermaVinsmoke avatar Oct 14 '19 18:10 GermaVinsmoke

Hi! I'll take this issue :)

Erick2280 avatar Oct 15 '19 02:10 Erick2280

Alright, thanks for the help. I added travis ci for auto-deployment, I hope it'll help.

GermaVinsmoke avatar Oct 15 '19 19:10 GermaVinsmoke

Hi, Can I take this issue?

nuwan94 avatar Oct 21 '19 12:10 nuwan94

Yeah @nuwan94

GermaVinsmoke avatar Oct 21 '19 12:10 GermaVinsmoke

@nuwan94 still on it? EDIT: If not can I take it?

CmdEngineer avatar Oct 21 '19 14:10 CmdEngineer

Will it be better to use .css files or better go with styled-components?

GermaVinsmoke avatar Oct 21 '19 15:10 GermaVinsmoke

I dont know

CmdEngineer avatar Oct 21 '19 15:10 CmdEngineer

@nuwan94 still on it? EDIT: If not can I take it?

Still asking @nuwan94

CmdEngineer avatar Oct 21 '19 15:10 CmdEngineer

Repo isn't even forked by him, so you can do it @CmdEngineer

GermaVinsmoke avatar Oct 21 '19 15:10 GermaVinsmoke

Alright

CmdEngineer avatar Oct 21 '19 15:10 CmdEngineer

@GermaVinsmoke Apparently MaterialCSS does have a big usage: image image

Buttons and the graph are unaffected

CmdEngineer avatar Oct 21 '19 15:10 CmdEngineer

The main thing is materialize-css grid - className="container" className="row" className="col " I think we can use flexbox instead of this. A lot of things will be solved with the help of flexbox.

The other thing is className="card". So, for this, I think it'll be better to use styled-components coz reusable Card component.

Removing materialize-css as it is having some security issues and I think we don't need it as it is having a size of 175kB (minified) and styled-components is having a size of 45kB (minified).

GermaVinsmoke avatar Oct 21 '19 16:10 GermaVinsmoke

materialize-css as it is having some security issues how does css introduce security issues?

CmdEngineer avatar Oct 21 '19 17:10 CmdEngineer

Suggestion: maybe use Spectre?

CmdEngineer avatar Oct 21 '19 18:10 CmdEngineer

materialize-css as it is having some security issues how does css introduce security issues?

Three of its javascript component are having vulnerabilities and there's no patch fix for that 🤔. So, if we're not using any of the JS Components then why to keep a module of that big size. I think that Spectre.css is cool and it'll work.

mat

GermaVinsmoke avatar Oct 22 '19 04:10 GermaVinsmoke