Geotrek-admin icon indicating copy to clipboard operation
Geotrek-admin copied to clipboard

Formset layout

Open bouttier opened this issue 2 years ago • 5 comments

bouttier avatar Sep 28 '22 14:09 bouttier



Test summary

22 0 0 0


Run details

Project Geotrek-admin
Status Passed
Commit 2e3335667f ℹ️
Started Sep 30, 2022 2:25 PM
Ended Sep 30, 2022 2:30 PM
Duration 04:44 💡
OS Linux Ubuntu - 20.04
Browser Electron 94

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] avatar Sep 29 '22 08:09 cypress[bot]

Codecov Report

Base: 98.11% // Head: 98.10% // Decreases project coverage by -0.00% :warning:

Coverage data is based on head (f71ea67) compared to base (d3dda3d). Patch coverage: 91.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3257      +/-   ##
==========================================
- Coverage   98.11%   98.10%   -0.01%     
==========================================
  Files         272      273       +1     
  Lines       19706    19727      +21     
==========================================
+ Hits        19334    19353      +19     
- Misses        372      374       +2     
Impacted Files Coverage Δ
geotrek/common/layouts.py 88.88% <88.88%> (ø)
geotrek/core/forms.py 95.60% <100.00%> (+0.04%) :arrow_up:
geotrek/maintenance/forms.py 100.00% <100.00%> (ø)
geotrek/trekking/forms.py 95.09% <100.00%> (+0.02%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 29 '22 09:09 codecov[bot]

Please add tests for missing lines Add cypress test for formsets ? Fix Trek form layout in advanced tab

Chatewgne avatar Sep 29 '22 09:09 Chatewgne

What about Fieldset(_('Lines')) in signage/forms.py ?

Chatewgne avatar Sep 29 '22 13:09 Chatewgne

There is still a display behaviour on the trek update page when using Formset for trek relationships

bouttier avatar Sep 30 '22 15:09 bouttier