QuickUMLS icon indicating copy to clipboard operation
QuickUMLS copied to clipboard

Issue 60 spacy entity overlap

Open burgersmoke opened this issue 4 years ago • 4 comments

This is an initial fix for what @soldni and I have discussed with spacy and overlapping entity spans. We may want to add additional match data later in an extension (i.e. the "underscore") but this works around an error for now.

https://github.com/Georgetown-IR-Lab/QuickUMLS/issues/60

burgersmoke avatar Sep 03 '20 22:09 burgersmoke

Sorry for the close/reopen but I was confused why this shows 4 commits instead of 1. The overall diff looks right, but please advise if there's a better way I should do this so that only the 1 commit (0dda67b) appears here.

burgersmoke avatar Sep 03 '20 22:09 burgersmoke

Hey @burgersmoke,

Just a quick note to let you know that I've seen this PR, but I don't quite have the bandwidth at the moment to look at it closely.... hoping to come back to it over the upcoming weekend at the latest!

-Luca

soldni avatar Sep 30 '20 04:09 soldni

That sounds great @soldni. I understand the limitations of bandwidth since I initially planned to submit these pull requests back in October 2019 and then lots of things got in my way.

burgersmoke avatar Sep 30 '20 18:09 burgersmoke

Any update on this pull request? And perhaps bumping the version number in PyPi?

We're about to do a major release of medspacy (https://github.com/medspacy/medspacy) and we wanted to include QuickUMLS in our default pipeline if we could.

burgersmoke avatar Dec 10 '20 01:12 burgersmoke