GeorgeJahad

Results 12 comments of GeorgeJahad

These lines are confusing to me: https://github.com/apache/ozone/blob/c7e922fb0c4d4c6c312bd717246c9fd8fde27e6f/hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java#L734-L738 I think something like this would be clearer: ``` Set currentLevel = new HashSet(); currentLevel.add(infileNode); Set nextLevel = new HashSet(); ```

This is in response to the discussion here: https://github.com/apache/ozone/pull/3786#discussion_r992935645 To me there is value in the conceptual simplicity of having all the state in rocksdb. And I don't think it...