GeorgeHop
feat: country picker modal with close button
Hey, I added a new feature for this lib: a close button when the modal is open. This increase de lib UX and allow manipulate the modal state easier.
Hey @GeorgeHop, May I expect a merge, else I need to patch this?
Why is this feature not merged? I had a requirement for close button in the country picker. So if it's merged, I shouldn't patch it.
@ShubhamAggarwal0812 @MufeedaFi I created my own country picker lib (with close button icluded) because this lib is so slow to update. So, if you are interested...this is the lib: react-native-country-select
Hey everyone! Thank you for using this lib.
I recommend using @AstrOOnauta's fork of this library, as he are actively maintaining it. I'm no longer interested in maintaining this project since it's mostly just a data package, and I don't find it particularly valuable from a UI/UX perspective.
Prebuilt or predefined UI components like the ones in this library often lack the level of customization required for well-designed apps. For example, my modal animation implementation isn't great—it's not even using Reanimated. If you're looking for a robust modal solution, I suggest using Gorhom's Bottom Sheet.
That said, feel free to reuse the data from this library. The community has helped keep it fairly up to date. Also, check out the data in @AstrOOnauta's version—he might have more recent country codes.
For rendering large lists (like country pickers), I recommend using FlashList from Shopify for better performance.
Finally, keep in mind: this package adds a significant amount of weight to your app as any other package with big amount of data—mainly due to the unicode emojis and bundled data. In a high-performance app, this kind of data is better fetched from a backend rather than bundled inside the app.
Big thanks to you all!
