pulsemixer icon indicating copy to clipboard operation
pulsemixer copied to clipboard

fix resizing upon winch events

Open williamvds opened this issue 4 years ago • 4 comments

shutil.get_terminal_size doesn't seem to update when threading is involved so just use os.get_terminal_size instead.

I'm using: GNU/Linux (Arch distro) Python 3.8.1 pulsemixer 1.5.1

I've tried using several terminal emulators, with and without tmux, and in each of these scenarios pulsemixer refuses to resize when I resize my terminal emulator window or tmux pane. This is a pretty simple fix, so hopefully it's acceptable.

williamvds avatar May 26 '20 19:05 williamvds

I don't seem to encounter this issue with either the old or the new version. Maybe it was fixed at some later Python version? I'm using Python 3.8.2.

sotpapathe avatar Jul 28 '20 14:07 sotpapathe

I'm now using Python 3.8.4 and still encountering this issue, so it doesn't seem to have been fixed through Python itself. This could be a Wayland issue, I'll try it on X11.

williamvds avatar Jul 29 '20 12:07 williamvds

Good point. I'm on X11.

sotpapathe avatar Jul 29 '20 16:07 sotpapathe

Just tried this on XFCE4: issue occurs without patch, but doesn't occur with patch

williamvds avatar Jul 29 '20 18:07 williamvds

This has been resolved on my system for a while now. I don't know when it was fixed or what the root cause was, but I'll close this anyhow.

williamvds avatar Jan 14 '24 16:01 williamvds