Tuba icon indicating copy to clipboard operation
Tuba copied to clipboard

"Follow back" button is always shown in notification, even if I was already following that human

Open nekohayo opened this issue 9 months ago • 5 comments

Describe the bug

If I was following someone, and they eventually follow me back, I get Tuba's notification about it, but the notification offers the "Follow back" button, even though I was already following them to ensure they were not doing mischievous stuff:

Image

Steps To Reproduce

  1. Secretly follow someone for a couple of months
  2. Successfully shitpost-bait them so that they follow you back after they snorted their coffee
  3. Notice the irrelevant "Follow back" button as shown above

Logs and/or Screenshots

See above...

Instance Backend

Mastodon

Operating System

Fedora 42

Package

Flatpak

Troubleshooting information

No response

Additional Context

No response

nekohayo avatar May 15 '25 18:05 nekohayo

🤔 not sure if we can do that in time but we can try I guess. To get the relationship between you and the user we need to do an extra API request and since we can't edit notifications once they are out on Linux, doing the extra request means withholding the notification until it's done

(😭 the issue description)

GeopJr avatar May 15 '25 18:05 GeopJr

To be honest, I'm more in favor of dropping both buttons as clicking the notification should open the profile which seems better as both actions are a bit destructive

GeopJr avatar May 15 '25 18:05 GeopJr

🤔 not sure if we can do that in time but we can try I guess. To get the relationship between you and the user we need to do an extra API request

Might be worthwhile to discuss if that could be added to the API upstream, we are suffering from the same issue in Moshidon, and I assume other clients will have the same issue.

FineFindus avatar May 15 '25 19:05 FineFindus

I think this is pretty much it: https://github.com/mastodon/mastodon/issues/33066

GeopJr avatar May 15 '25 19:05 GeopJr

Huh, I thought the "accounts you follow" was locally cached information... in any case, personally it would not shock me if a "new follower" notification took a second more to process before showing, it makes no material difference for user experience whether this notification arrives within 0 second vs 3 seconds, no?

nekohayo avatar May 16 '25 02:05 nekohayo