volesti icon indicating copy to clipboard operation
volesti copied to clipboard

Fix examples and CI integration

Open vissarion opened this issue 3 years ago • 16 comments

Is your feature request related to a problem? Please describe. Even after the useful PR https://github.com/GeomScale/volesti/pull/190 some examples are still failing to compile.

Describe the solution you'd like Some have an easy fix e.g. vpolytope-volume while some other e.g. EnvelopeProblemSOS need some work to fix the cmake (at least in my Ubuntu 20.04 with gcc version 9.3.0 I am getting an error Target "EnvelopeProblem" links to target "Python2::Python" but the target was not found after running cmake .).

Additional context The ultimate solution would integrate all examples to be build in our CI (i.e. github actions) then we will be sure that future changes will not break them.

vissarion avatar Dec 10 '21 09:12 vissarion

Hi I'd like to contribute to this. This seems to be me a very exciting repo where I can explore and develope new skills in programming. Kindly assign me this issue....

Sajal193 avatar Dec 15 '21 21:12 Sajal193

@Sajal193 thanks for your interest in the project, please go ahead and submit a PR, providing as much information as possible.

vissarion avatar Dec 16 '21 09:12 vissarion

As I'm new to this tech stack, I'm acquiring data to be able to understand the issue properly and then make a PR

Sajal193 avatar Dec 19 '21 04:12 Sajal193

Thank you for considering me for the role

Sajal193 avatar Dec 19 '21 04:12 Sajal193

Hi i'd like to contribute to this issue. i am new to GitHub so please guide me how to get started with this issue . i have doubt that how i search in the codes in this repo for this issue. please explain me more about this issue

Sharmalm avatar Jan 09 '22 16:01 Sharmalm

Hi i'd like to contribute to this issue. i am new to GitHub so please guide me how to get started with this issue . i have doubt that how i search in the codes in this repo for this issue. please explain me more about this issue

Thanks for your interest in the project!

Regarding getting started with github there are plenty of useful docs https://docs.github.com/en/get-started

As for this issue we essentially like to build volesti examples using github actions. If you have any specific question please let us know.

vissarion avatar Jan 09 '22 20:01 vissarion

i don't able to understand this issue .can you please elaborate how to approach solution to this problem .

Sharmalm avatar Jan 10 '22 18:01 Sharmalm

I tried to fix Cmake. I wanted to ask if a new .yml file is expected to compile CMakeLists of all examples?

shahpratham avatar Feb 19 '22 11:02 shahpratham

There is no need for a new .yml files but the current one could compile all the examples after or before compiling and executing all tests.

vissarion avatar Feb 21 '22 15:02 vissarion

I'd like to work on this issue if still possible!

Rajat1206 avatar Feb 26 '22 14:02 Rajat1206

Hii @vissarion. To compile CMakeList of examples/optimization_spectrahedra, we need these libraries openblas, lapack and arpack. It would be somewhat difficult to add this in github actions to install this, according to the steps mentions on how to compile.

So should I skip compiling it? Rest all examples are successfully compiling in the CI.

shahpratham avatar Feb 27 '22 08:02 shahpratham

Hi i'd like to contribute to this issue. i have some ideas for this issue I want to try on this ,kindply please assign this issue

himanshuParashar0101 avatar Feb 27 '22 17:02 himanshuParashar0101

hey @himanshuParashar0101. I have almost completed this issue, I just wanted to ask whether to include compilation of examples/optimization_spectrahedra in github actions as it requires installation of openlas lapack and arpack.

shahpratham avatar Feb 28 '22 08:02 shahpratham

hey @himanshuParashar0101. I have almost completed this issue, I just wanted to ask whether to include compilation of examples/optimization_spectrahedra in github actions as it requires installation of openlas lapack and arpack.

hey @himanshuParashar0101. I have almost completed this issue, I just wanted to ask whether to include compilation of examples/optimization_spectrahedra in github actions as it requires installation of openlas lapack and arpack.

yess

himanshuParashar0101 avatar Mar 03 '22 17:03 himanshuParashar0101

i would like to try my hand to this issue if possible

adibapatel avatar Feb 19 '23 06:02 adibapatel

@adibapatel please have a look at this https://github.com/GeomScale/volesti/pull/265

vissarion avatar Feb 20 '23 08:02 vissarion