dingo icon indicating copy to clipboard operation
dingo copied to clipboard

Consider renaming `biomass_function` routine

Open hariszaf opened this issue 1 year ago • 3 comments

Should we rename this to objective function ? This way when we are not using the biomass function as objective we will not have misunderstandings.

hariszaf avatar Dec 11 '23 09:12 hariszaf

I suppose this only involves renaming the biomass_function to objective_function and then modifying the calls to biomass_function accordingly? If so, I can make these changes.

hritikb avatar Apr 23 '24 13:04 hritikb

Thanks a lot @hritikb for your support. Of course you may go ahead with this task, but please let the biomass_index as is, so people can always find its index easy. Also make sure you rename this variable through the whole repo, including tests and tutorials.

hariszaf avatar Apr 23 '24 14:04 hariszaf

I have opened a PR for this (#97). You may please take a look.

hritikb avatar Apr 24 '24 13:04 hritikb