dingo icon indicating copy to clipboard operation
dingo copied to clipboard

Dockerfile is added to the codebase

Open ai-naymul opened this issue 2 years ago • 8 comments

The dockerfile is added which use the Gurobi docker image

Fixes #78

ai-naymul avatar Sep 15 '23 06:09 ai-naymul

@ai-naymul thanks for this PR.

I think it is better if we add that file inside doc maybe in a directory called docker or something that will contain that file and a README with instructions on how to use it. As for example, https://volesti.readthedocs.io/en/latest/getting_started/install.html#development-environment-from-docker-container

@hariszaf what do you think?

@ai-naymul ideally a github action could be added to test that the dockerfile works as expected.

vissarion avatar Sep 15 '23 12:09 vissarion

@ai-naymul thanks for this PR.

I think it is better if we add that file inside doc maybe in a directory called docker or something that will contain that file and a README with instructions on how to use it. As for example, https://volesti.readthedocs.io/en/latest/getting_started/install.html#development-environment-from-docker-container

@hariszaf what do you think?

@ai-naymul ideally a github action could be added to test that the dockerfile works as expected.

Yeah we should add that instructions stuff after the installation section in the README file...

ai-naymul avatar Sep 15 '23 14:09 ai-naymul

@vissarion should I work on the readme file instruction part of these PR right now and make a commit in the same pr or make another PR regarding that?

ai-naymul avatar Sep 19 '23 08:09 ai-naymul

I think it is better to do it in this PR. Do you confirm that the docker file you wrote works? What are the commands such that we can reproduce that? Are you able to build dingo in that container and run the tests?

vissarion avatar Sep 19 '23 08:09 vissarion

Hi @vissarion and @ai-naymul

here you may find a working Dockerfile.

as I do not know if that's in a best-practices way, please have a look and share thoughts. :taco:

hariszaf avatar Sep 20 '23 15:09 hariszaf

I think it is better to do it in this PR. Do you confirm that the docker file you wrote works? What are the commands such that we can reproduce that? Are you able to build dingo in that container and run the tests?

Okay I will make the changes

ai-naymul avatar Sep 22 '23 14:09 ai-naymul

I tried this Dockerfile and its current version fails. Maybe if you follow the steps described inline, it might work.

Oh..I didn't notice that the gurobi is not in pypi library , I am sorry I will fix this asap

ai-naymul avatar Sep 22 '23 14:09 ai-naymul

@hariszaf @vissarion could you please check the recent commit...!!

ai-naymul avatar Sep 23 '23 10:09 ai-naymul