Geoffrey Booth

Results 642 comments of Geoffrey Booth

Why is it necessary to use external versions? Could Debian’s patch be integrated into Uncici’s version somehow? We include a wasm binary for the https://github.com/nodejs/cjs-module-lexer dependency that’s also bundled in...

Next time please tag @nodejs/loaders. The transpilation use case is already covered by that API, and it’s not clear to me how a separate entrypoint phase would be a better...

> Loaders doesn’t help us for CJS, which is the vast majority of code out there. The current loaders API can be extended to support CommonJS. It’s been a low...

> My goal for this hook is to reach a state where the following user experience is possible The user experience of ts-node is literally `ts-node script.ts`. I'm not sure...

> The proposal just states that loaders are addressing a different problem, which they do. @jasnell I’m sure you didn’t intend this, but from the perspective of those who’ve worked...

Starting with your last question first: > Could/would loaders be a good fit for that? This is what loaders _are._ They’re user-defined logic for customizing module resolution and loading, and...

> If the user wants a scripting runtime with native TS support, then the required `NODE_OPTIONS` variable can get messy. I agree; I think in practice most people would just...

> I’m not sure if we could do that without stopping the event loop. If code that’s running in `--import` includes top-level `await`, wouldn’t that be equivalent to stopping and...

> You can basically see it if you change the variable in [https://github.com/nodejs/node/blob/main/lib/internal/modules/run_main.js#L76](https://github.com/nodejs/node/blob/main/lib/internal/modules/run_main.js?rgh-link-date=2022-07-28T14%3A55%3A07Z#L76) of `useESMLoader` to always being `true` and a bunch of async_hooks core tests will fail due to...

> In event loop lingo, ESM starts with a loop that’s already processing (we did load files and let the event loop spin), while CJS starts with a timer. What...