Mathias LANG
Mathias LANG
It looks like a lot could be simplified and built purely on top of the existing `Statement` primitive. Also you should squash the commits.
What we do is adding it to `LIB`: https://github.com/bpfkorea/agora/blob/537ca3be259d5aa76698e14fc97a3e61de1bab5c/.github/workflows/main.yml#L101
> Or would omitting the unit test be fine for Meson builds? IMO it would be fine to omit as long as it doesn't prevent testing Meson. In other words,...
Thanks for the fast reduction! Reported as https://issues.dlang.org/show_bug.cgi?id=21989 . That's pretty bad :/
Vibe.d policy is to only support the last 10 versions, which is better than most other libraries out there.
@SingingBush : Sorry this fell off the radar. I'm happy to merge if you can rebase (and drop 2.089 I guess)
Switching to delegate means an extra allocation. I'm not sure that's what we want. Could you look into: - Marking the parameter as `scope`; - Passing a pointer to `Exception`...
> We should probably do something about the toString situation, though Any suggestion ?
v2.097.0 will come with a fix for this, leaving open for now as it's not yet released (and until it's the oldest supported release).
> Although this is not a large amount of memory It also means that a GC cycle can kick in (GC cycles can only trigger if an allocation happens), which...