georaster-layer-for-leaflet icon indicating copy to clipboard operation
georaster-layer-for-leaflet copied to clipboard

almost there!

Open DanielJDufour opened this issue 2 years ago • 6 comments

test with

npm install georaster-layer-for-leaflet@next

DanielJDufour avatar Dec 01 '23 00:12 DanielJDufour

If I zoom in far enough to see pixels I get a "polys is not defined" error from https://github.com/GeoTIFF/dufour-peyton-intersection/blob/f38f16ce87d71be685a46f399847ee5cd96f69a1/src/calculate.js#L7 Reported as https://github.com/GeoTIFF/dufour-peyton-intersection/issues/4

jcphill avatar Jan 25 '24 02:01 jcphill

Also not sure how to reproduce the behavior of the old getProjector() function (with no arguments) that would return a transform from raster coordinates to (longitude, latitude).

jcphill avatar Jan 25 '24 03:01 jcphill

@jcphill , great catch. I missed that. I'll add in the getProjector function and make sure we have backwards compatibility for those documented functions. Thank you!

DanielJDufour avatar Jan 26 '24 01:01 DanielJDufour

When I have multiple georaster layers loaded at the same time somehow the tile lists are getting crossed. If I change which layer is attached to the map the tiles don't update but if I pan the map then new tiles are added from the new raster. Tiles can even end up drawn on the wrong pane.

jcphill avatar Jan 26 '24 03:01 jcphill

@jcphill , just a quick update. I re-added some of the backwards compatibility, especially focusing on getProjector. It should have the same functionality if you call it without arguments. I published a new next version to NPM, so npm install georaster-layer-for-leaflet@next should install this new version.

to-dos:

I still need to do the following:

  • publish new version of georaster
  • updated/republish all the libs that use dufour-peyton-interesection, fixing "polys is not defined" error.
  • debug issue with multiple georasters and tile lists getting crossed you reported above

Thank you for all your help testing this new version!!!

DanielJDufour avatar Feb 04 '24 16:02 DanielJDufour

Please see https://github.com/GeoTIFF/georaster-layer-for-leaflet/pull/132/files#r1687367106 for the likely cause of the crossed tile lists issue I reported in January.

jcphill avatar Jul 23 '24 03:07 jcphill