geonode icon indicating copy to clipboard operation
geonode copied to clipboard

[Fixes #12455] Map thumbnails extent always cover the whole globe

Open mattiagiupponi opened this issue 1 year ago • 1 comments

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • [x] Confirm you have read the contribution guidelines
  • [x] You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • [x] Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • [x] There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • [x] The issue connected to the PR must have Labels and Milestone assigned
  • [x] PR for bug fixes and small new features are presented as a single commit
  • [x] Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • [ ] New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • [x] This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • [x] This PR passes the QA checks: black geonode && flake8 geonode
  • [ ] Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • [ ] Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

mattiagiupponi avatar Jul 30 '24 12:07 mattiagiupponi

Codecov Report

Attention: Patch coverage is 73.91304% with 6 lines in your changes missing coverage. Please review.

Project coverage is 64.15%. Comparing base (2e4dae2) to head (a52900d). Report is 27 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12460      +/-   ##
==========================================
- Coverage   64.16%   64.15%   -0.01%     
==========================================
  Files         888      888              
  Lines       53465    53469       +4     
  Branches     6596     6598       +2     
==========================================
- Hits        34304    34303       -1     
+ Misses      17651    17649       -2     
- Partials     1510     1517       +7     

codecov[bot] avatar Jul 30 '24 13:07 codecov[bot]

@mattiagiupponi the calculated box is wrong, as you can see from the thumbnail of this layer for Italy.

image

I also verified the extent coordinates reported inside the API response and they are actually wrong (consistent with the thumbnail area)

image

giohappy avatar Sep 18 '24 09:09 giohappy

@mattiagiupponi @giohappy thanks !

kikislater avatar Sep 18 '24 16:09 kikislater