geonode icon indicating copy to clipboard operation
geonode copied to clipboard

[Fixes #11995 Implement POST and PATCH methods for the User API

Open mattiagiupponi opened this issue 11 months ago • 2 comments

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • [x] Confirm you have read the contribution guidelines
  • [ ] You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • [x] Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • [x] There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • [ ] The issue connected to the PR must have Labels and Milestone assigned
  • [x] PR for bug fixes and small new features are presented as a single commit
  • [x] Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • [x] New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • [x] This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • [ ] This PR passes the QA checks: black geonode && flake8 geonode
  • [ ] Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • [ ] Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

mattiagiupponi avatar Mar 01 '24 16:03 mattiagiupponi

⚠️ GitGuardian has uncovered 7 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9702486 Triggered Generic Password 4bad53a658736852b14cfc7a48eb6ef057cf9812 geonode/people/tests.py View secret
9702486 Triggered Generic Password ee071e28e274cc76e7233a58d08f810ccd274a45 geonode/people/tests.py View secret
9702486 Triggered Generic Password 26c940f8a6ecaa40ad3c68780243b254a512e01f geonode/people/tests.py View secret
9702487 Triggered Username Password 4bad53a658736852b14cfc7a48eb6ef057cf9812 geonode/people/tests.py View secret
9702487 Triggered Username Password 26c940f8a6ecaa40ad3c68780243b254a512e01f geonode/people/tests.py View secret
9705160 Triggered Username Password c0c4dfbb61d444530830a0683d00897197fdc5a8 geonode/base/api/tests.py View secret
9768717 Triggered Username Password ee071e28e274cc76e7233a58d08f810ccd274a45 geonode/people/tests.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

gitguardian[bot] avatar Mar 01 '24 16:03 gitguardian[bot]

Codecov Report

Merging #12011 (26c940f) into ISSUE_11995 (023761d) will increase coverage by 0.13%. The diff coverage is 99.46%.

Additional details and impacted files
@@               Coverage Diff               @@
##           ISSUE_11995   #12011      +/-   ##
===============================================
+ Coverage        63.67%   63.81%   +0.13%     
===============================================
  Files              867      867              
  Lines            52664    52843     +179     
  Branches          6600     6609       +9     
===============================================
+ Hits             33535    33720     +185     
+ Misses           17610    17598      -12     
- Partials          1519     1525       +6     

codecov[bot] avatar Mar 01 '24 16:03 codecov[bot]