cant install with geonode-project for inconsistent requierements.txt and setup.cfg

[cesarbenjamindotnet]

trafficstars

Expected Behavior

finish installation

Actual Behavior

actually don't complete, log throws an error about old fashioned urls settings incompatible with current django versions, this happens because setup.cfg has:

django-geonode-mapstore-client>=4.0.5,<5.0.0
geonode-importer>=1.0.2

instead of

django_geonode_mapstore_client @ git+https://github.com/GeoNode/geonode-mapstore-client@master#egg=django_geonode_mapstore_client
geonode-importer @ git+https://github.com/GeoNode/geonode-importer.git@master#egg=geonode-importer

as in requirements.txt

i guess requirements.txt can be fine for manuall install and twice other, but geonode-project uses pip install geonode and for the way that is build the package it uses setup.cfg configs.

i did an update and PR but was rejected, please keep requirements.txt and setup.cfg consistent

Steps to Reproduce the Problem

1. install via geonode project
2. fail
3. see log

Specifications

• GeoNode version: master
• Installation type (vanilla, geonode-project): geonode-project
• Installation method (manual, docker): docker
• Platform: ubuntu 22.04
• Additional details:

[giohappy]

@cesar-benjamin the way the requirements and setup.cfg files are laid out in geonode and geonode-project has always worked. There might be a problem with the latest versions, but we did a few builds during the past days with no issues.

• setup.cfg is used when you install geonode from a geonode-project
• if the geonode-project has a fixed version for geonode (e.g. in a releases like 4.2.2) it will select the most recent version from PyPI or the fixed version set in GeoNode (e.g. for 4.2.2 they are fixed
• if the geonode-project installs geonode from git (either in develop mode or not), as in development branches, the range of versions set in GeoNode setup.cfg will be compatible wit the version downloaded from git

You mention a log file in the issue description. Did you forget to attack it?

[cesarbenjamindotnet]

i mean the build console log, i don't know where that can be recover of it is saven somewhere. But i try to say that when i use geonde-project master it try to build geonode master and dont build because setup.cfg uses importer and mapstore client versions which got errors for incompatibility

[cesarbenjamindotnet]

can you please update the setup.cfg to be consistent with requirements.txt? the actual state causes that can't be complete the install with geonode-project

[giohappy]

@cesar-benjamin to be honest I still don't understand what's the issue with your geonode projects. We build them very frequently with no issues. Can you please point me to the exact places where you're having problems?

[cesarbenjamindotnet]

Exactly at the ./docker-build.sh from geonode-project install mode. Because it uses the pypi whl dependency from geonode-whatever.whl which uses setup.cfg dependencies not requirements.txt I don't understand why is difficult to understand that requirements.txt and setup.cfg have differences in a couple of packages which are not compatible, setup.cfg must be updated to match each dependency equal in requirements and setup. Or can't be installed using docker-build because y example mapstore client is different in both and the one which exists in setup.cfg is not updated to work with django 4.2 yet. This case happens with 3 or 4 packages

The only thing that mis be done is her due that dependencies are the same in both files, exactly updating setup.cfg to match requirements.txt exactly equals.

[erwaen]

@cesar-benjamin Hi, did you figure out how to fix this or maybe how to up the project?

[cesarbenjamindotnet]

@cesar-benjamin Hi, did you figure out how to fix this or maybe how to up the project?

sure, please check my setup.cfg and edit yours, you can get it here: https://github.com/gobiernodigitalmonterrey/geonode/blob/datos_mty/setup.cfg

you have to fork geonode, edit setup.cfg in your fork, and then using geonode-project, edit the src/requirements,txt like this: https://github.com/gobiernodigitalmonterrey/geonode-project/blob/datos_mty/src/requirements.txt

Only be careful with geonode-importer in requirements.txt and setup.cfg, please use the oficial one, because i'm using a custom one that implements a few non standar features like csv table upload as dataset as you can see here: https://mide.monterrey.gob.mx

[kikislater]

I think this is fixed now as build downloads from pypi... Build from git is development mode IMO

[cesarbenjamindotnet]

I think this is fixed now as build downloads from pypi... Build from git is development mode IMO

i'm working on development mode, i don't understand your comment.