geoda icon indicating copy to clipboard operation
geoda copied to clipboard

apply vs return

Open lanselin opened this issue 8 years ago • 8 comments

in many dialogs (example, set the lowess parameters), one needs to click the "apply" button explicitly. it would be nice to also have the return key serve that purpose. it does in some dialogs, but not consistently.

lanselin avatar Mar 13 '16 00:03 lanselin

Please verify in 1.8.11.

Will keep this ticket open for a longer time testing.

lixun910 avatar Mar 13 '16 05:03 lixun910

Verified in GeoDa 1.7.99 (OSX Yosemite, 10.10.5 and Win 7 Professional (64-bit)).

Nat.shop, correlogram

Apply doesn't yet respond to clicking on return key. Mouse-clicking on apply does work.

jkoschinsky avatar Mar 24 '16 19:03 jkoschinsky

Please verify in 1.7.101

lixun910 avatar Mar 25 '16 18:03 lixun910

GeoDa 1.7.101 (OSX Yosemite, 10.10.5 and Win 7 Professional (64-bit)).

Apply in correlogram works now.

Apply or run doesn't yet work in: --averages chart (e.g. if you select run Diff-in-Diff and then select Apply) --variable calculation (table) --selection tool (table) --regression

The rest of the views (e.g. variable selection) are based on OK where Enter also doesn't work. Question is if we only want to enable Enter for Apply and Run or also for OK.

jkoschinsky avatar Mar 29 '16 02:03 jkoschinsky

For now, due to the limitation of wxWidgets, you need to capture ENTER event for every controls in the view to implement this "return" feature. For example, in regression dialog, you need to hook up ENTER event with all the listctrls, and option ctrols, even the dialog panel itself. This is not a good design at all.

For some views, which have text input as major controls (user will hit ENTER when finished typing), implementing this "return" feature is reasonable. For example, the lowess parameters. I would suggest only implement this "return" feature on this type of views.

lixun910 avatar Apr 05 '16 23:04 lixun910

works for me

jkoschinsky avatar Apr 08 '16 16:04 jkoschinsky

1.8.16.35 - Windows 8 Verified

YidanJ-Wu avatar May 30 '17 17:05 YidanJ-Wu

OS X El Capitan 10.11.6 GeoDa 1.12.1.137 -in correlogram, when changing the correlogram parameters (variable, distance buns, ext...) the correlogram itself automatically updates without pressing apply or enter Other enter key options: //**summary a lot of the OKs and Run don't work with enter button, but it would be a nice edition -in creating a weight, you have to press create/enter button does not work (could be nice if it did) -in KMedoids also need to press run instead of enter -creating bubble charts need to press OK/enter does not work

VeraB620 avatar Jun 30 '18 16:06 VeraB620