qgis-bridge-plugin icon indicating copy to clipboard operation
qgis-bridge-plugin copied to clipboard

Added GN parameter options - group, assignToCatalog, transformwith.

Open ByronCinNZ opened this issue 3 years ago • 5 comments

Extra parameters to allow flexibility on how GN handles uploaded metadata.

ByronCinNZ avatar Mar 15 '22 01:03 ByronCinNZ

Agree with all your comments.

Yes, empty strings seem to work fine for “assignToCatalog” and "transformWith"

Yes, Group ID is better name. But an upgrade to this script would use the textual group name and translate it

UK or US spelling for “catalogue” - not sure consistency currently exist So whichever you prefer

Yes to the radio button for “assignToCatalog” but a bit confused by the value that GN accepts for this - “on” for true and blank for false is what works for me and how it is used in the “Insert Metadata” function in GN (the api indicates true/false but I have had no success with the GN Swagger api for this)

Cheers, Byron

On 16/03/2022, at 12:22 AM, Sander Schaminee @.***> wrote:

@GeoSander commented on this pull request.

In geocatbridge/servers/views/geonetwork.ui https://github.com/GeoCat/qgis-bridge-plugin/pull/148#discussion_r826862648:

  •     </widget>
    
  •    </item>
    
  •    <item row="4" column="1">
    
  •     <widget class="QLineEdit" name="txtGeonetworkGroup">
    
  •      <property name="text">
    
  •       <string/>
    
  •      </property>
    
  •      <property name="placeholderText">
    
  •       <string>Group Id</string>
    
  •      </property>
    
  •     </widget>
    
  •    </item>
    
  •    <item row="5" column="0">
    
  •     <widget class="QLabel" name="label_35">
    
  •      <property name="text">
    
  •       <string>Assign to current Catalogue</string>
    

Also, since this is a boolean, we should perhaps turn this into a radio button or something 🤔

— Reply to this email directly, view it on GitHub https://github.com/GeoCat/qgis-bridge-plugin/pull/148#discussion_r826862648, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIJCPAR2OFIEJBROURYPGDVABXHXANCNFSM5QXHZWDQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.

ByronCinNZ avatar Mar 15 '22 19:03 ByronCinNZ

Alright, thanks @ByronCinNZ.

Yes to the radio button for “assignToCatalog” but a bit confused by the value that GN accepts for this

Oof... that's nasty. Let me try out some things and find out what works best. This may very well be GN version-specific. Speaking of which: what GN version are you on?

But an upgrade to this script would use the textual group name and translate it

Not completely sure what you mean here, but Bridge for ArcMap actually queries all groups first on GN and populates a dropdown with available values (using the group name for display purposes and a numeric identifier as the actual value for each group). I could do the same for Bridge for QGIS of course, which I think is what you meant?

GeoSander avatar Mar 15 '22 22:03 GeoSander

For groups, yes a query for group name to populate a dropdown is what I was thinking

ByronCinNZ avatar Mar 22 '22 20:03 ByronCinNZ

I am on GN 3.12.2

ByronCinNZ avatar Apr 19 '22 22:04 ByronCinNZ

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jan 23 '25 22:01 CLAassistant