scrcpy icon indicating copy to clipboard operation
scrcpy copied to clipboard

Show touch

Open AndroidDeveloperLB opened this issue 7 years ago • 35 comments

In developer options, there is an option "show taps", that whenever you touch the screen, a white circle appears. For some reason, it doesn't appear when using this app. Please let us have it. It can be useful for screenshots and screen-video capture.

AndroidDeveloperLB avatar Mar 11 '18 21:03 AndroidDeveloperLB

For some reason, it doesn't appear when using this app.

Yes, injecting events does not display the circle. It is probably triggered at lower level. Nothing we can do IMO. So I'm closing.

Feel free to reopen if there is a technical solution.

rom1v avatar Mar 11 '18 22:03 rom1v

Why close it then? How about putting your own circle? One that shows 2 states: the mouse position, and then pressing on it. Or using those of Google's material design website: https://material.io/guidelines/patterns/gestures.html#gestures-drag-swipe-or-fling-details

Something like these videos: https://storage.googleapis.com/material-design/publish/material_v_12/assets/0Bwp7jtSjaW36RUJ4TnJjTnZ0dms/patterns-selection-item-entering1.webm https://storage.googleapis.com/material-design/publish/material_v_12/assets/0Bwp7jtSjaW36WHQ1eFc5aW44QlU/patterns-selection-item-controlling2.webm https://storage.googleapis.com/material-design/publish/material_v_12/assets/0Bwp7jtSjaW36QWo0S01faE5Sa0U/patterns-selection-item-controlling1.webm

It's even better than the simple circle.

AndroidDeveloperLB avatar Mar 11 '18 23:03 AndroidDeveloperLB

Please re-consider

AndroidDeveloperLB avatar Mar 11 '18 23:03 AndroidDeveloperLB

@rom1v Thank you. Here's one that shows long clicking: https://storage.googleapis.com/material-design/publish/material_v_12/assets/0B-IfCW5OG7FqU09tc3kxOGg3aTA/notifications-behavior-08-controls-xhdpi.webm

AndroidDeveloperLB avatar Mar 12 '18 00:03 AndroidDeveloperLB

In developer options, there is an option "show taps", that whenever you touch the screen, a white circle appears.

At least, I added an option to enable show touches while scrcpy is running: https://github.com/Genymobile/scrcpy/issues/96.

rom1v avatar Mar 29 '18 08:03 rom1v

I have 1.1, and I don't see "touches" of the mouse. Only when I touch the screen myself (with the finger).

AndroidDeveloperLB avatar Mar 29 '18 08:03 AndroidDeveloperLB

I have 1.1, and I don't see "touches" of the mouse. Only when I touch the screen myself (with the finger).

  1. It only enable the show touches option in developer settings (so you will only see physical touches, not mouse clicks, technically it is probably implemented in some code that event injection does not trigger).
  2. it's implemented in dev (not released yet).
  3. The application must be started with scrcpy --show-touches.

rom1v avatar Mar 29 '18 08:03 rom1v

Well I have it enabled anyway in the settings of the OS... But what I wrote here, is that I'd like to see the touches indications (and maybe even customize them and have new ones, like the links of material design I've shown) on the PC app itself.

AndroidDeveloperLB avatar Mar 29 '18 08:03 AndroidDeveloperLB

Yes, I got it.

I just notified that I added an option to automatically enable/disable the setting in developers options, because it is somehow related.

I didn't say I implemented what you requested (that's why I left the issue open).

rom1v avatar Mar 29 '18 08:03 rom1v

I see. Say, is it possible to somehow be notified of new versions of this tool? Maybe a specific website URL that I can monitor via this website: https://www.changedetection.com/login.html ? I just think it's such a nice tool. I wish it would have been a part of the IDE itself.

AndroidDeveloperLB avatar Mar 29 '18 09:03 AndroidDeveloperLB

Say, is it possible to somehow be notified of new versions of this tool?

I don't know, maybe: https://github.com/Genymobile/scrcpy/releases.atom

In the future, I hope it will be packaged in distributions (it is already packaged for Arch Linux and Homebrew for MacOS, so the update is automatic).

rom1v avatar Mar 29 '18 09:03 rom1v

I use Windows... And the website url you've provided is blocked, because it has "robots.txt" file. :(

AndroidDeveloperLB avatar Mar 29 '18 09:03 AndroidDeveloperLB

I use Windows...

Sorry for you :trollface:

And the website url you've provided is blocked, because it has "robots.txt" file.

The URL is an rss/atom feed, you can use any feed reader.

rom1v avatar Mar 29 '18 09:03 rom1v

Haha. I like Linux only for development (and I hate the UX of MacOS), and I used it a very long time ago. But for the past years I got Windows at the office.

About rss/atom, ok.

AndroidDeveloperLB avatar Mar 29 '18 09:03 AndroidDeveloperLB

I've now registered to this for the Atom/Rss of github: https://ifttt.com/applets/400948p-get-notifications-about-github-releases

I hope it works.

AndroidDeveloperLB avatar Mar 29 '18 09:03 AndroidDeveloperLB

I've noticed this is possible now:

image

But when I try it , I still don't see it:

image

AndroidDeveloperLB avatar May 28 '18 23:05 AndroidDeveloperLB

This is just https://github.com/Genymobile/scrcpy/issues/44#issuecomment-377170279

rom1v avatar May 29 '18 05:05 rom1v

@rom1v Isn't it a new feature? If not, why mention it? I can see v1.2 was out just some hours ago:

image

AndroidDeveloperLB avatar May 29 '18 05:05 AndroidDeveloperLB

Isn't it a new feature? If not, why mention it?

The feature was implemented 2 months ago in the dev branch, but it was after the last release v1.1. This is the first time it is released.

rom1v avatar May 29 '18 05:05 rom1v

Well it doesn't work for me. In fact it disabled the touch indication I had before

AndroidDeveloperLB avatar May 29 '18 06:05 AndroidDeveloperLB

It enables it on start, and disable it on stop. If you let it enabled, just don't use the option.

When you touch the screen with your finger, it should show touches.

rom1v avatar May 29 '18 06:05 rom1v

@rom1v I've removed the flag. Still can't see the touches using the mouse. See video:

ice_video_20180529-094117.zip

Also, almost sure it's because of this app: On first run, the mouse couldn't get to reach the taskbar of the Windows OS itself. Instead it gets hidden. On next runs, it didn't happen. Weird thing is that I didn't see it on a different PC, so not 100% sure it's because of this.

AndroidDeveloperLB avatar May 29 '18 06:05 AndroidDeveloperLB

I've removed the flag. Still can't see the touches using the mouse.

I'm not sure you understand what the feature does.

From scrcpy --help:

    -t, --show-touches
        Enable "show touches" on start, disable on quit.
        It only shows physical touches (not clicks from scrcpy).

So:

  • if you don't pass the flag, it does not change the "show touches" option (if it was enabled, it stays enabled)
  • if you pass the flag, it enable it on start, and disable it on quit
  • the "show touches" option only display physical touches

ice_video_20180529-094117.zip

(don't zip videos :wink:)

On first run, the mouse couldn't get to reach the taskbar of the Windows OS itself. Instead it gets hidden. On next runs, it didn't happen.

Weird.

rom1v avatar May 29 '18 07:05 rom1v

So it doesn't show touches for the PC app. Only touches on the phone itself. Please add feature to show mouse "touches". Now that I re-read what I wrote here (sorry I forgot about it), it's the same as I wrote originally on this thread.

About uploading videos, Github doesn't allow to upload them directly. It can only allow specific files types.

AndroidDeveloperLB avatar May 29 '18 07:05 AndroidDeveloperLB

+1

This feature will be very useful in automation. Without this, it's really hard to get touch position from video or picture. But it's not an easy job I think :(

minitouch is an available option (maybe).

williamfzc avatar Dec 13 '18 11:12 williamfzc

@rom1v If it's impossible to cause the touch indicators appear on the device itself, it could be nice to show them just on the window of ScrCpy alone. Have a flag for this, as some people might not want it.

AndroidDeveloperLB avatar Jun 30 '21 00:06 AndroidDeveloperLB

IMHO we can close this since we have -t, --show-touches option. @rom1v .

twaik avatar Oct 11 '22 13:10 twaik

@twaik No, I already wrote about this: https://github.com/Genymobile/scrcpy/issues/44#issuecomment-392679621

AndroidDeveloperLB avatar Oct 11 '22 15:10 AndroidDeveloperLB

I always spread scrcpy among all the devs that I work with. And this is something that we really need on daily basis - like to show something on my screen during a video call or record the screen video.

Looking forward to get this function working. I would be really useful.

-t does not work for me

allco avatar Feb 16 '23 16:02 allco

@allco He talks about real touches. The request I made is for "simulated" touches (by the mouse).

AndroidDeveloperLB avatar Feb 16 '23 16:02 AndroidDeveloperLB