scrcpy icon indicating copy to clipboard operation
scrcpy copied to clipboard

desktop-file-validate fails on provided .desktop files

Open zenofile opened this issue 1 year ago • 0 comments

  • [x] I have read the FAQ.

  • [x] I have searched in existing issues.

  • scrcpy version: 1.25

During the packaging of scrcpy for Fedora COPR, I noticed both scrcpy.desktop and scrcpy-console.desktop do not pass the desktop-file-validate validation process:

scrcpy.desktop

$ desktop-file-validate scrcpy.desktop
scrcpy.desktop: error: value "/bin/sh -c '"$SHELL" -i -c scrcpy'" for key "Exec" in group "Desktop Entry" contains a reserved character ''' outside of a quote
scrcpy.desktop: error: value "/bin/sh -c '"$SHELL" -i -c scrcpy'" for key "Exec" in group "Desktop Entry" contains a non-escaped character '$' in a quote, but it should be escaped with two backslashes ("\\$")
scrcpy.desktop: error: value "/bin/sh -c '"$SHELL" -i -c scrcpy'" for key "Exec" in group "Desktop Entry" contains a reserved character ''' outside of a quote
scrcpy.desktop: hint: value item "RemoteAccess" in key "Categories" in group "Desktop Entry" can be extended with another category among the following categories: Network

scrcpy-console.desktop

$ desktop-file-validate scrcpy-console.desktop 
scrcpy-console.desktop: error: value "/bin/bash --norc --noprofile -i -c '"$SHELL" -i -c scrcpy || read -p "Press any key to quit..."'" for key "Exec" in group "Desktop Entry" contains a reserved character ''' outside of a quote
scrcpy-console.desktop: error: value "/bin/bash --norc --noprofile -i -c '"$SHELL" -i -c scrcpy || read -p "Press any key to quit..."'" for key "Exec" in group "Desktop Entry" contains a non-escaped character '$' in a quote, but it should be escaped with two backslashes ("\\$")
scrcpy-console.desktop: error: value "/bin/bash --norc --noprofile -i -c '"$SHELL" -i -c scrcpy || read -p "Press any key to quit..."'" for key "Exec" in group "Desktop Entry" contains a reserved character '|' outside of a quote
scrcpy-console.desktop: error: value "/bin/bash --norc --noprofile -i -c '"$SHELL" -i -c scrcpy || read -p "Press any key to quit..."'" for key "Exec" in group "Desktop Entry" contains a reserved character '|' outside of a quote
scrcpy-console.desktop: error: value "/bin/bash --norc --noprofile -i -c '"$SHELL" -i -c scrcpy || read -p "Press any key to quit..."'" for key "Exec" in group "Desktop Entry" contains a reserved character ''' outside of a quote
scrcpy-console.desktop: hint: value item "RemoteAccess" in key "Categories" in group "Desktop Entry" can be extended with another category among the following categories: Network

zenofile avatar Dec 22 '22 15:12 zenofile