genymotion-device-web-player icon indicating copy to clipboard operation
genymotion-device-web-player copied to clipboard

Closing & reopening the webrtc connection loses the mouse & keyboard inputs

Open skornous opened this issue 5 months ago • 0 comments

Description

Since the rework of v4 a bug was present where if you closed & reopened the WebRTC WebSocket you'd lose the inputs from both mouse & keyboard.

After some tests it appears that unregistering the mouse & keyboard events in the store on WebSocket disconnection & then re-registering them when creating the peer connection (as for the touch & gamepad events) fixes this issue.

This PR is the aforementioned fix.

Sorry but as it's quite a technical issue, it's hard to provide a simple screen-record so you'll have to trust me on this 😬

Fixes #(no related issue)

Type of change

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • [x] I've read & comply with the contributing guidelines
  • [x] I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • [x] I have made corresponding changes to the documentation (README.md).
  • [x] I've checked my modifications for any breaking changes.

skornous avatar Sep 23 '24 15:09 skornous