mixs icon indicating copy to clipboard operation
mixs copied to clipboard

pcr_cond provides structure and example in description

Open mslarae13 opened this issue 1 year ago • 3 comments

Descriptions shouldn't have an example in it.

"Description of reaction conditions and components of PCR in the form of 'initial denaturation:94degC_1.5min; annealing=...'"

recommended change

"Description of reaction conditions and components of polymerase chain reaction performed during library preparation'

mslarae13 avatar Jan 04 '24 01:01 mslarae13

I'm inclined to not go looking for things like this, but I agree with the principle of removing examples from descriptions when we have to make other updates to a term, or where the example is wrong or misleading. If the TWG want to include this minor update in the next PR/comit thats fine by me (as long as there is an example in the correct linkML field).

only1chunts avatar Jan 05 '24 15:01 only1chunts

@only1chunts I'm happy to work on issues like this.

mslarae13 avatar Jan 13 '24 00:01 mslarae13

I would like to ask.. which example is right?

  - value: initial denaturation:94_3;annealing:50_1;elongation:72_1.5;final elongation:72_10;35
  - value: initial denaturation:94degC_1.5min

with our without degC?

mslarae13 avatar Jan 13 '24 00:01 mslarae13