mixs icon indicating copy to clipboard operation
mixs copied to clipboard

Update CONTRIBUTING.md

Open pbuttigieg opened this issue 2 years ago • 8 comments

Started the extension of the CONTRIBUTING.Md doc - more content should be added so devs know what and how to edit to maintain and extend MIxS.

Closes #615

pbuttigieg avatar Oct 17 '23 16:10 pbuttigieg

@turbomam @sujaypatil96 - this PR targets main.

Is that right or is there a branch to stage the release?

pbuttigieg avatar Oct 17 '23 16:10 pbuttigieg

@pbuttigieg: there's a merge conflict. Do you prefer for the issues and pulls links to appear before or after your new text about modifying mixs.yaml?

turbomam avatar Oct 19 '23 13:10 turbomam

Before - that information is more general than my additions, so should appear first

pbuttigieg avatar Oct 19 '23 14:10 pbuttigieg

I resolved the merge conflict by placing @pbuttigieg's new content after the links about issues and pull requests

turbomam avatar Nov 06 '23 18:11 turbomam

@pbuttigieg I think I havw covered or will cover this content in https://github.com/GenomicsStandardsConsortium/mixs/tree/606-mixs-editing-workflow-and-policy. May I close this PR without merging?

ramonawalls avatar Dec 29 '23 00:12 ramonawalls

@ramonawalls

I think I havw covered or will cover this content in https://github.com/GenomicsStandardsConsortium/mixs/tree/606-mixs-editing-workflow-and-policy. May I close this PR without merging?

This linked to a long-running branch with many changes from multiple people. I made a PR for this to make it easier to see the changes:

https://github.com/GenomicsStandardsConsortium/mixs/pull/617/files

However, it looks like @pbuttigieg's PR has independent and useful contributions on how to find the yaml file to edit, etc, so I would like to merge this.

Also, can I make a plea for

  • smaller, incremental PRs
  • breaking larger pieces of work into smaller
  • no long running branches
  • always having a PR for each branch to make it more visible
  • faster decisions and merges on smaller PRs

Otherwise things get out of sync. This PR is from October. The linked PR is from 5 months ago. All of the good work in these PRs is not yet visible on the site. I know it's hard as we are volunteering time but some simple changes in practice can help us make use of our time more effectively

cmungall avatar Apr 05 '24 21:04 cmungall

Very old PR. Should we merge main and merge this? @turbomam @pbuttigieg

mslarae13 avatar Jul 18 '24 00:07 mslarae13

@mslarae13 yes, but @turbomam to verify content is still current

pbuttigieg avatar Jul 18 '24 00:07 pbuttigieg