Clarify the lock icon in the toolbar

[humdingerb]

I mistook the pad lock icon to actually make the file permissions read-only. I wondered about the usefulness of that... Then I figured that it only protected the open file against accidental changes. Maybe change the tool-tip to "Write protect". Could add a lock symbol to the tab label as well: 🔒 (U+1F512, there doesn't seem to be a 2D version of a lock...)

[jackburton79]

I think it needs to be improved, too. I'm not so sure the one you proposed Is more effective, though. Maybe "block modifications" or something like that? Unfortunately it will have to wait for the release after this one (3.0), since we are busy testing and decided to only do bugfixes for critical stuff until the v2 release

[humdingerb]

Wording's not easy... "Prevent changes", maybe. You'll think of something... :)

[jackburton79]

The lock character in the Tab Is also a nice touch, I think

[humdingerb]

That, or "disabling" the tab label so its text is a light grey. The universal sign that you can look but not touch.

[jackburton79]

In #279 I gave it a shot

[humdingerb]

While it's nice to have an actual icon in the tab, it grabs too much attention being yellow. Also when a file gets locked/unlocked, the dis/appearing lock icon results in the colour blob and filename jump left/right. How about using a greyscale icon at the right of the filename.

BTW, the text and widgets aren't perfectly vertically aligned.

[humdingerb]

To add: I just realized that adding/removing the lock icon changes the tab width. This introduced unnecessary business in the GUI. Maybe having a blank, transparent bitmap there for "unlocked" avoids that? Or something more sophisticated by computing something or other to set the tab width...

[jackburton79]

While it's nice to have an actual icon in the tab, it grabs too much attention being yellow. Also when a file gets locked/unlocked, the dis/appearing lock icon results in the colour blob and filename jump left/right. How about using a greyscale icon at the right of the filename.

Yep, my fellow co-developers said so themselves. Will try to do that.

[jackburton79]

Making the tab look "disabled" is a bit more involved than I thought, since it requires touching various parts of the code. I guess I'll postpone this feature