Genio icon indicating copy to clipboard operation
Genio copied to clipboard

Double-click on error in build log to jump into source

Open humdingerb opened this issue 1 year ago • 13 comments

I think I remember this already working before, but I may just imagine this... Also, I can't totally parse #11, this may be a duplicate.

humdingerb avatar Dec 06 '23 08:12 humdingerb

Not sure about this: if I click on the error it definitely jumps into the source file where the build error is. Isn't it working for you?

jackburton79 avatar Dec 17 '23 18:12 jackburton79

It definitely did not work back then. I remember having to manually find the file and line. Very annoying... :) It works now, underlining and all. Thanks!.

humdingerb avatar Dec 18 '23 06:12 humdingerb

Hmm... now it doesn't work any more again... I tried with the v2 version from HaikuDepot and building the current "main" branch. I tried removing the Genio settings folder. Still no build error jumping. Any ideas?

humdingerb avatar Dec 28 '23 16:12 humdingerb

Does the project path contain a space?

nexus6-haiku avatar Dec 28 '23 16:12 nexus6-haiku

Nope, it's /Source/KeyCursor. No spaces in file names either.

humdingerb avatar Dec 28 '23 16:12 humdingerb

If it still happen, please increase the log level to Trace set the destination to syslog/BeDC to try to collect some information. Thanks!

Freaxed avatar Dec 31 '23 17:12 Freaxed

It works with other projects, but for some reason fails for "KeyCursor". Attached the Trace syslog, and the zipped up project folder. Maybe it works for you...(?)

For the trace, I just removed a semicolon. A build failure is shown with the exact line it occurs, but I cannot double-click it...

build-syslog.txt KeyCursor.zip

BTW, is "BeDC" this thing: BDirectConnect ? How do you use it?

humdingerb avatar Jan 01 '24 10:01 humdingerb

The only suspect line is

USER: Genio: {T} Can't find path /Source/KeyCursor/preflet/KeyCursor

Is there a file, folder or symlink with that name? I can't spot it in the zip file (I'm checking from my iPhone so not the best tool to look into this).

BeDC stands for Developer Console, is an old tool from the BeOS days that PulkoMandy has revived for Haiku 64bit.

nexus6-haiku avatar Jan 01 '24 10:01 nexus6-haiku

That would be the built preflet binary.

I didn't find BeDC in HaikuDepot. ..

humdingerb avatar Jan 01 '24 10:01 humdingerb

Ok I can reproduce it but cleary we cannot do much here. The same 'bug' can be seen in Terminal by compiling, then pressing the B_CONTROL_KEY and move the mouse cursor over KeyCursorFilter.cpp.. no way to select and to open it. This is due the fact that the makefile doesn't express file location relative to the root folder and Genio is not able to locate the it. When the mouse moves over the text and algo is extracting the possible 'path' and checking if it does exist as an absolute or relative path. Maybe we could also search the list of all the project's files but it could be a bit heavy to be performed on mouse move.

Freaxed avatar Jan 01 '24 11:01 Freaxed

Maybe we can just check whether it's not an absolute path and assume the root is the working directory (this should already be the project's folder, I think)?

nexus6-haiku avatar Jan 01 '24 16:01 nexus6-haiku

The complication here is that there are two Makefiles in two subfolders of the project and one Makefile in the project folder that calls those other Makefiles...

humdingerb avatar Jan 01 '24 16:01 humdingerb

I don't think we can understand the cwd of a separate running process.. moreover is can change while running and after stopping

Freaxed avatar Jan 01 '24 16:01 Freaxed

Let's close this for now, as there is nothing we can do, unfortunately.

jackburton79 avatar May 26 '24 11:05 jackburton79