pygmt icon indicating copy to clipboard operation
pygmt copied to clipboard

Add load_* functions to support more remote relief datasets

Open seisman opened this issue 2 years ago • 11 comments
trafficstars

Description of the desired feature

The GMT side is working on the lunar relief dataset for remote use and it's close to being finished (https://github.com/GenericMappingTools/gmtserver-admin/issues/167). Similar to other load_earth_* functions (xref https://github.com/GenericMappingTools/pygmt/issues/1786), we need to add a load_moon_relief function to download and load the data.

  • [x] Moon relief dataset https://github.com/GenericMappingTools/pygmt/pull/2674
  • [x] Mars relief dataset https://github.com/GenericMappingTools/pygmt/pull/2847
  • [x] Mercury relief dataset https://github.com/GenericMappingTools/pygmt/pull/3028
  • [x] Pluto relief dataset https://github.com/GenericMappingTools/pygmt/pull/3027
  • [x] Venus relief dataset #2906
  • [ ] CNES Earth Distance to Shoreline https://www.generic-mapping-tools.org/remote-datasets/earth-dist.html
  • [ ] IGPP Earth Free-Air Anomaly Errors https://www.generic-mapping-tools.org/remote-datasets/earth-faaerror.html
  • [ ] IGPP Earth East-West Deflections https://www.generic-mapping-tools.org/remote-datasets/earth-edefl.html
  • [ ] CNES Earth Mean Sea Surface https://www.generic-mapping-tools.org/remote-datasets/earth-mss.html
  • [ ] CNES Earth Mean Dynamic Topography https://www.generic-mapping-tools.org/remote-datasets/earth-mdt.html
  • [ ] IGPP Earth South-North Deflections https://www.generic-mapping-tools.org/remote-datasets/earth-ndefl.html

seisman avatar Mar 16 '23 05:03 seisman

Would like to work on this if the GMT-side implementation is done!

michaelgrund avatar Mar 16 '23 08:03 michaelgrund

Not just the Moon. Also Mercury, Venus, Mars and Pluto.

Esteban82 avatar Mar 19 '23 01:03 Esteban82

Not just the Moon. Also Mercury, Venus, Mars and Pluto.

Thanks, I've updated the PR title.

seisman avatar Mar 19 '23 03:03 seisman

As shown in https://github.com/GenericMappingTools/gmtserver-admin/issues/219, the building of the planetary relief datasets is almost finished. These new datasets are still not available on the GMT main server but are available on the candidate server (http://candidate.generic-mapping-tools.org/server/).

I think @PaulWessel decided to release these new datasets at the same time as the GMT 6.5 release, which may happen shortly (maybe in a few weeks).

It would be great if we could add load_* function to support these new datasets. When the new datasets are released with GMT 6.5, we can add the following sentence to the announcement:

You may also want to try the latest PyGMT dev version, which already provides the load_xxx_relief functions to help you load these new datasets as xarray.DataArray.

We can also decide if these new functions are worth a new PyGMT release, i.e., releasing GMT 6.5, the new datasets, and PyGMT v0.11.0 at the same day, although PyGMT v 0.10.0 was released only a few days ago.

seisman avatar Sep 09 '23 03:09 seisman

I think @PaulWessel decided to release these new datasets at the same time as the GMT 6.5 release, which may happen shortly (maybe in a few weeks).

Most likely, because in order to access the highest resolution of the some planets a new GMT version is needed (see https://github.com/GenericMappingTools/gmtserver-admin/issues/171#issuecomment-1650082556). Maybe will you have the same issue?

Esteban82 avatar Sep 09 '23 12:09 Esteban82

I think @PaulWessel decided to release these new datasets at the same time as the GMT 6.5 release, which may happen shortly (maybe in a few weeks).

Most likely, because in order to access the highest resolution of the some planets a new GMT version is needed (see GenericMappingTools/gmtserver-admin#171 (comment)). Maybe will you have the same issue?

Didn't realize the issue yet. Will read and see what happens.

seisman avatar Sep 09 '23 12:09 seisman

We can also decide if these new functions are worth a new PyGMT release, i.e., releasing GMT 6.5, the new datasets, and PyGMT v0.11.0 at the same day, although PyGMT v 0.10.0 was released only a few days ago.

Probably just need a patch release (v0.10.1) to support GMT 6.5? Depends on how backward incompatible things are. It sounds like most other functions should still be ok, just the remote datasets are affected.

weiji14 avatar Sep 09 '23 12:09 weiji14

Depends on how backward incompatible things are. It sounds like most other functions should still be ok, just the remote datasets are affected.

See https://github.com/GenericMappingTools/gmtserver-admin/issues/171 for more discussions if you're interested. As far as I can see, there are no backward incompatibilities between 6.4 and 6.5. GMT 6.4 can access all these new remote datasets except a few full-resolution grids (e.g., pluto grid with a 52.0732883317s increment), while GMT 6.5 can.

Probably just need a patch release (v0.10.1) to support GMT 6.5?

The point is to provide more load functions (e.g., load_moon_relief in PR #2674) to load the new datasets into xarray.DataArray object. These are new features and should be included in v0.11.0. The question is, do we want to release v0.11.0 in Jan, 2024 following our quarterly release policy, or release earlier, on the same day as GMT 6.5.

seisman avatar Sep 12 '23 00:09 seisman

The question is, do we want to release v0.11.0 in Jan, 2024 following our quarterly release policy, or release earlier, on the same day as GMT 6.5.

When is the planned release date for GMT 6.5? October? November?

weiji14 avatar Sep 19 '23 02:09 weiji14

The question is, do we want to release v0.11.0 in Jan, 2024 following our quarterly release policy, or release earlier, on the same day as GMT 6.5.

When is the planned release date for GMT 6.5? October? November?

Ping @PaulWessel

seisman avatar Sep 19 '23 04:09 seisman

We are close but I have many non-GMT days next 2 weeks so maybe Oct 15

PaulWessel avatar Sep 19 '23 05:09 PaulWessel