pygmt icon indicating copy to clipboard operation
pygmt copied to clipboard

pygmt.datasets.load_earth_relief() now returns gridline-registrated grids by default in GMT 6.4

Open seisman opened this issue 2 years ago • 1 comments

Description of proposed changes

See https://github.com/GenericMappingTools/pygmt/issues/1929 for context.

Fixes https://github.com/GenericMappingTools/pygmt/issues/1929.

Reminders

  • [ ] Run make format and make check to make sure the code follows the style guide.
  • [ ] Add tests for new features or tests that would have caught the bug that you're fixing.
  • [ ] Add new public functions/methods/classes to doc/api/index.rst.
  • [ ] Write detailed docstrings for all functions/methods.
  • [ ] If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • [ ] If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

seisman avatar Aug 12 '22 12:08 seisman

The docs are periodically failing with timeouts due to this change (e.g., https://github.com/GenericMappingTools/pygmt/runs/7813705141?check_suite_focus=true). We could prevent this by adding "@earth_relief_10m_g" to https://github.com/GenericMappingTools/pygmt/blob/5a8a5ccd83a062e2409645dc1adba2c4030b20ba/pygmt/helpers/testing.py#L148.

maxrjones avatar Aug 12 '22 21:08 maxrjones