gmt icon indicating copy to clipboard operation
gmt copied to clipboard

Ex52: figure is loaded externally

Open anbj opened this issue 1 year ago • 6 comments

I've built the docs locally, and ex52 actually loads the image from https://user-images.githubusercontent.com/14077947/123172626-62ca6880-d44b-11eb-8d91-21e448930460.png.

Deliberate?

I would expect it to load a locally generated version/dvc version, so that you don't need an internet connection to see it.

anbj avatar May 16 '24 18:05 anbj

You're talking about ex53, right?

The example ex53 was initially added in #5336. We didn't add the ex53.ps file into the repository because, the PS file is too large (~10 MB) and at that time we haven't set up DVC yet.

But now, since we already have DVC set up, I think it's time to add the PS image to DVC.

seisman avatar May 17 '24 02:05 seisman

Yes, Ex53! Sorry.

anbj avatar May 17 '24 06:05 anbj

Add the ~10 MB ex53.ps to DVC is fine, but the problem is, when we make the GMT release, the large PS file is also included in the GMT tarball, which can significant increase the size of the tarball.

seisman avatar May 23 '24 01:05 seisman

Ok. So not do it and close? 10 MB is alot for one figure.

anbj avatar May 23 '24 06:05 anbj

I'm considering whether we should not include the original PS files in tarballs. If not, then the 10 MB PS file won't be a problem.

seisman avatar May 23 '24 07:05 seisman

I agree we shouldn't.

joa-quim avatar May 23 '24 19:05 joa-quim

Close?

joa-quim avatar Jan 06 '25 20:01 joa-quim

Sure. But do we do anything about this?

anbj avatar Jan 06 '25 21:01 anbj

Closing.

anbj avatar Oct 04 '25 08:10 anbj