Dylan Page

Results 93 comments of Dylan Page

A good example of this is due to the changes in #2131 implementing path in the locker: https://github.com/runatlantis/atlantis/pull/2131/files#diff-034e4dc5f6cb962a86c96f1cafb7f29daaa33496dd5f94f514f3017b5c862fc0R50 Which `DefaultRepoRelDir` is set to `.`: https://github.com/runatlantis/atlantis/blob/96ab0ab2e7e2d39b9b59f3486904e20a97bed359/server/events/project_command_builder.go#L27 When you have multiple projects...

There's a couple other draft PRs that have gone stale around handling cloning and the working_dir_locker #2882 and #2921 I think overall we should probably have a solid approach to...

Maintainer here, I agree with Luke's opinion here. Make sure docs are updated and clear that this isn't an intended feature for logging but to prevent VCS PR comment bloat...

@glasser Let's not limit it by default in this PR, but please make sure in the docs that we plan to default in the future. This will give people some...

@dbmurphy Can you add a comment on why the test calls are commented out with Paths being the out-of-scope cause, that way someone else coming along can understand.

@dbmurphy Are you able to follow up on this?

if there are no updates by next week, I'll take a look and merge. I don't want to block a PR on a code comment.

@kirstus @jseiser @mvdkleijn After reviewing, it makes sense to me that we can get away with supporting Gitea without overloading the existing GHE client interface. We can always refactor down...

@mvdkleijn Correct, I wouldn't be opposed to additional logic in a wrapper function to compensate for the lack of support for Gitea in go-github. I would envision an entirely separate...

> > I think that makes sense, but it should break existing server-side and repos configurations. 🤔 > > Could use a new variable like `repo_locks = off|plan|apply` and deprecate...