react-twitter-auth icon indicating copy to clipboard operation
react-twitter-auth copied to clipboard

Sending verification code in POST body?

Open sdob opened this issue 6 years ago • 2 comments

Hi,

The component is great, and is about 99% perfect for our use case; thanks for writing it! We'd like to be able to send the verifier and token to our loginUrl endpoint in the request body — rather than in the query string — like so:

{"oauth_verifier" "xxxxxxx", "oauth_token": "xxxxxxx"}

We've forked it to do so, but obviously we'd rather contribute upstream than maintain our own fork. :-) Would you be willing to consider a fleshed-out pull request with the request style (query vs. body) as an optional prop?

sdob avatar Sep 12 '18 13:09 sdob

Hi @sdob,

Sorry for late response. I was on vacation and I was not using my laptop :D

I would be very interested to accept your PR. Please, feel free to create PR. I will do some testing and merge it into master.

I really appreciate your effort.

ivanvs avatar Sep 18 '18 10:09 ivanvs

I have to clone and modify this component because it was missing this feature. Sending data in URL parameters for POST seams wrong.

Kif11 avatar Jun 24 '19 19:06 Kif11